From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jooyung Han <jooyung@google.com>,
Mike Snitzer <snitzer@kernel.org>,
zkabelac@redhat.com, dm-devel@lists.linux.dev,
Alasdair Kergon <agk@redhat.com>,
Dan Schatzberg <schatzberg.dan@gmail.com>
Subject: Re: [PATCH V2 3/5] loop: move command blkcg/memcg initialization into loop_queue_work
Date: Thu, 20 Mar 2025 08:14:08 +0100 [thread overview]
Message-ID: <20250320071408.GC14337@lst.de> (raw)
In-Reply-To: <20250314021148.3081954-4-ming.lei@redhat.com>
On Fri, Mar 14, 2025 at 10:11:43AM +0800, Ming Lei wrote:
> Move loop command blkcg/memcg initialization into loop_queue_work,
> and prepare for supporting to handle loop io command by IOCB_NOWAIT.
As a cosmetic change this looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
But based on my digging into this code from the current discussion
I really thing we need to kill the blkcg loop_worker code with
prejudice ASAP in favor of a per-command work_struct.
next prev parent reply other threads:[~2025-03-20 7:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 2:11 [PATCH V2 0/5] loop: improve loop aio perf by IOCB_NOWAIT Ming Lei
2025-03-14 2:11 ` [PATCH V2 1/5] loop: simplify do_req_filebacked() Ming Lei
2025-03-20 7:10 ` Christoph Hellwig
2025-03-14 2:11 ` [PATCH V2 2/5] loop: cleanup lo_rw_aio() Ming Lei
2025-03-20 7:11 ` Christoph Hellwig
2025-03-14 2:11 ` [PATCH V2 3/5] loop: move command blkcg/memcg initialization into loop_queue_work Ming Lei
2025-03-20 7:14 ` Christoph Hellwig [this message]
2025-03-14 2:11 ` [PATCH V2 4/5] loop: try to handle loop aio command via NOWAIT IO first Ming Lei
2025-03-14 2:11 ` [PATCH V2 5/5] loop: add hint for handling aio via IOCB_NOWAIT Ming Lei
2025-03-20 7:22 ` Christoph Hellwig
2025-03-20 7:38 ` Ming Lei
2025-03-14 2:16 ` [PATCH V2 0/5] loop: improve loop aio perf by IOCB_NOWAIT Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320071408.GC14337@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=jooyung@google.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=schatzberg.dan@gmail.com \
--cc=snitzer@kernel.org \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.