From: Simon Horman <horms@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
Amit Cohen <amcohen@nvidia.com>,
mlxsw@nvidia.com
Subject: Re: [PATCH net-next 1/6] mlxsw: Trap ARP packets at layer 2 instead of layer 3
Date: Thu, 20 Mar 2025 15:57:54 +0000 [thread overview]
Message-ID: <20250320155754.GD889584@horms.kernel.org> (raw)
In-Reply-To: <b2a2cc607a1f4cb96c10bd3b0b0244ba3117fd2e.1742224300.git.petrm@nvidia.com>
On Mon, Mar 17, 2025 at 06:37:26PM +0100, Petr Machata wrote:
> From: Amit Cohen <amcohen@nvidia.com>
>
> Next patch will set the same hardware domain for all bridge ports,
> including VXLAN, to prevent packets from being forwarded by software when
> they were already forwarded by hardware.
>
> ARP packets are not flooded by hardware to VXLAN, so software should handle
> such flooding. When hardware domain of VXLAN device will be changed, ARP
> packets which are trapped and marked with offload_fwd_mark will not be
> flooded to VXLAN also in software, which will break VXLAN traffic.
>
> To prevent such breaking, trap ARP packets at layer 2 and don't mark them
> as L2-forwarded in hardware, then flooding ARP packets will be done only
> in software, and VXLAN will send ARP packets.
>
> Remove NVE_ENCAP_ARP which is no longer needed, as now ARP packets are
> trapped when they enter the device.
>
> Signed-off-by: Amit Cohen <amcohen@nvidia.com>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
> Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-03-20 15:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 17:37 [PATCH net-next 0/6] mlxsw: Add VXLAN to the same hardware domain as physical bridge ports Petr Machata
2025-03-17 17:37 ` [PATCH net-next 1/6] mlxsw: Trap ARP packets at layer 2 instead of layer 3 Petr Machata
2025-03-20 15:57 ` Simon Horman [this message]
2025-03-17 17:37 ` [PATCH net-next 2/6] mlxsw: spectrum: Call mlxsw_sp_bridge_vxlan_{join, leave}() for VLAN-aware bridge Petr Machata
2025-03-20 15:58 ` Simon Horman
2025-03-17 17:37 ` [PATCH net-next 3/6] mlxsw: spectrum_switchdev: Add an internal API for VXLAN leave Petr Machata
2025-03-20 15:58 ` Simon Horman
2025-03-17 17:37 ` [PATCH net-next 4/6] mlxsw: spectrum_switchdev: Move mlxsw_sp_bridge_vxlan_join() Petr Machata
2025-03-20 15:58 ` Simon Horman
2025-03-17 17:37 ` [PATCH net-next 5/6] mlxsw: Add VXLAN bridge ports to same hardware domain as physical bridge ports Petr Machata
2025-03-20 16:00 ` Simon Horman
2025-03-17 17:37 ` [PATCH net-next 6/6] selftests: vxlan_bridge: Test flood with unresolved FDB entry Petr Machata
2025-03-20 16:00 ` Simon Horman
2025-03-24 22:20 ` [PATCH net-next 0/6] mlxsw: Add VXLAN to the same hardware domain as physical bridge ports patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320155754.GD889584@horms.kernel.org \
--to=horms@kernel.org \
--cc=amcohen@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.