From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 909041DE3B1 for ; Thu, 20 Mar 2025 15:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742486294; cv=none; b=aDrSngoZ2z4kcoLi6hiWnq7mHHZ7BCwqCDthRXEK+VxiIhirhF00xx4cqIXmXXaW7vs6j+r0a7ufomaljIUBOimdfpSQZMsRsGKkhlOnqQFy7ZFQ1fOsFIMqhb9Efm9SC2EWqGvAb5kxieGszffAOyX4U86WypRSFK6epavjvs0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742486294; c=relaxed/simple; bh=kcqaWaumOxOGTUjyeHV2ylx4Os3nXY9dbZE8xGxNJcQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VgYZmoNE9P6G7xKdZUAsOH6HuPANnt7CIQHRcJJ8OzDvbBsbainEH7RBn+Rhh6tfX439aq6KCUtTmm/Z78ZTCiy11ywhqul9XoGaA9kae2QrkmJQpt/8k366ihtdUdLHVdvnYMKB6ueYjgkYtwI253o5zRp7+jo1jN6IEXJkvK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XJFg6eRB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XJFg6eRB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17A57C4CEDD; Thu, 20 Mar 2025 15:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742486294; bh=kcqaWaumOxOGTUjyeHV2ylx4Os3nXY9dbZE8xGxNJcQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XJFg6eRBeWUtKq15himGoO7M+hDGGCHVzTyjV2N3nCLVbxy//37/+dJcdxfyFZIel VVzD8q7ru+syJb7dBIRsuGI9XCO9JcBHao65mOuDR8JsWC97P491YW/lIc9x60MGIA O7NK7Wx9iSQiKiFopd+rC09rkxubFqmVxJpczDqiv2MNUiR2uEAt8Hhn6xM1InUxD5 bD7l1Iiwm99DCbAlDo+kqkUCm2Evu9UB/Kb+26lxFKOZDgbpnRkWE8m5UIisl7MCMd mz+Qq2lzDTxf4o0AVr4LFDvBXvSTC92Mdk7f0xtvqZaxW2fxA1v29StUfjQVdFLHoj 06UYHDoRg9xAg== Date: Thu, 20 Mar 2025 15:58:10 +0000 From: Simon Horman To: Petr Machata Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , netdev@vger.kernel.org, Ido Schimmel , Amit Cohen , mlxsw@nvidia.com Subject: Re: [PATCH net-next 2/6] mlxsw: spectrum: Call mlxsw_sp_bridge_vxlan_{join, leave}() for VLAN-aware bridge Message-ID: <20250320155810.GE889584@horms.kernel.org> References: <994c1ea93520f9ea55d1011cd47dc2180d526484.1742224300.git.petrm@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <994c1ea93520f9ea55d1011cd47dc2180d526484.1742224300.git.petrm@nvidia.com> On Mon, Mar 17, 2025 at 06:37:27PM +0100, Petr Machata wrote: > From: Amit Cohen > > mlxsw_sp_bridge_vxlan_{join,leave}() are not called when a VXLAN device > joins or leaves a VLAN-aware bridge. As mentioned in the comment - when the > bridge is VLAN-aware, the VNI of the VXLAN device needs to be mapped to a > VLAN, but at this point no VLANs are configured on the VxLAN device. This > means that we can call the APIs, but there is no point to do that, as they > do not configure anything in such cases. > > Next patch will extend mlxsw_sp_bridge_vxlan_{join,leave}() to set hardware > domain for VXLAN, this should be done also when a VXLAN device joins or > leaves a VLAN-aware bridge. Call the APIs, which for now do not do anything > in these flows. > > Align the call to mlxsw_sp_bridge_vxlan_leave() to be called like > mlxsw_sp_bridge_vxlan_join(), only in case that the VXLAN device is up, > so move the check to be done before calling > mlxsw_sp_bridge_vxlan_{join,leave}(). This does not change the existing > behavior, as there is a similar check inside mlxsw_sp_bridge_vxlan_leave(). > > Signed-off-by: Amit Cohen > Reviewed-by: Petr Machata > Reviewed-by: Ido Schimmel > Signed-off-by: Petr Machata Reviewed-by: Simon Horman