All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: bhelgaas@google.com, rafael@kernel.org, ojeda@kernel.org,
	alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
	bjorn3_gh@protonmail.com, benno.lossin@proton.me,
	a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
	linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] rust: device: implement Device::parent()
Date: Thu, 20 Mar 2025 18:40:56 -0700	[thread overview]
Message-ID: <2025032018-perceive-expectant-5c48@gregkh> (raw)
In-Reply-To: <20250320222823.16509-2-dakr@kernel.org>

On Thu, Mar 20, 2025 at 11:27:43PM +0100, Danilo Krummrich wrote:
> Device::parent() returns a reference to the device' parent device, if
> any.

Ok, but why?  You don't use it in this series, or did I miss it?

A driver shouldn't care about the parent of a device, as it shouldn't
really know what it is.  So what is this needed for?

thanks,

greg k-h

  parent reply	other threads:[~2025-03-21  1:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 22:27 [PATCH v2 0/4] Implement TryFrom<&Device> for bus specific devices Danilo Krummrich
2025-03-20 22:27 ` [PATCH v2 1/4] rust: device: implement Device::parent() Danilo Krummrich
2025-03-20 22:44   ` Benno Lossin
2025-03-20 23:46     ` Danilo Krummrich
2025-03-21  1:40   ` Greg KH [this message]
2025-03-21  9:04     ` Danilo Krummrich
2025-03-21 13:03       ` Danilo Krummrich
2025-03-21 13:09         ` Greg KH
2025-03-21 14:16           ` Danilo Krummrich
2025-03-21 14:40   ` Boqun Feng
2025-03-21 14:46     ` Danilo Krummrich
2025-03-20 22:27 ` [PATCH v2 2/4] rust: device: implement bus_type_raw() Danilo Krummrich
2025-03-20 22:55   ` Benno Lossin
2025-03-20 22:27 ` [PATCH v2 3/4] rust: pci: impl TryFrom<&Device> for &pci::Device Danilo Krummrich
2025-03-20 23:44   ` Benno Lossin
2025-03-20 23:48     ` Danilo Krummrich
2025-03-21 16:56   ` kernel test robot
2025-03-21 17:44     ` Danilo Krummrich
2025-03-21 18:59       ` Miguel Ojeda
2025-03-21 19:11         ` Danilo Krummrich
2025-03-21 19:37           ` Miguel Ojeda
2025-03-22 10:08     ` Benno Lossin
2025-03-20 22:27 ` [PATCH v2 4/4] rust: platform: impl TryFrom<&Device> for &platform::Device Danilo Krummrich
2025-03-20 23:44   ` Benno Lossin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025032018-perceive-expectant-5c48@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.