From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Yicong Yang <yangyicong@huawei.com>
Cc: <will@kernel.org>, <mark.rutland@arm.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <hejunhao3@huawei.com>,
<prime.zeng@hisilicon.com>, <linuxarm@huawei.com>,
<yangyicong@hisilicon.com>, <wangyushan12@huawei.com>
Subject: Re: [PATCH v2 3/8] drivers/perf: hisi: Use ACPI driver_data to retrieve SLLC PMU information
Date: Fri, 21 Mar 2025 11:13:18 +0000 [thread overview]
Message-ID: <20250321111318.0000455e@huawei.com> (raw)
In-Reply-To: <20250321073846.23507-4-yangyicong@huawei.com>
On Fri, 21 Mar 2025 15:38:41 +0800
Yicong Yang <yangyicong@huawei.com> wrote:
> From: Junhao He <hejunhao3@huawei.com>
>
> Make use of struct acpi_device_id::driver_data for version specific
> information rather than judge the version register. This will help
> to simplify the probe process and also a bit easier for extension.
>
> Factor out SLLC register definition to struct hisi_sllc_pmu_regs.
> No functional changes intended.
>
> Signed-off-by: Junhao He <hejunhao3@huawei.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2025-03-21 11:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 7:38 [PATCH v2 0/8] General updates and two new drivers for HiSilicon Uncore PMU Yicong Yang
2025-03-21 7:38 ` [PATCH v2 1/8] drivers/perf: hisi: Simplify the probe process for each DDRC version Yicong Yang
2025-03-21 7:38 ` [PATCH v2 2/8] drivers/perf: hisi: Add support for HiSilicon DDRC v3 PMU driver Yicong Yang
2025-03-21 7:38 ` [PATCH v2 3/8] drivers/perf: hisi: Use ACPI driver_data to retrieve SLLC PMU information Yicong Yang
2025-03-21 11:13 ` Jonathan Cameron [this message]
2025-03-21 7:38 ` [PATCH v2 4/8] drivers/perf: hisi: Add support for HiSilicon SLLC v3 PMU driver Yicong Yang
2025-03-21 7:38 ` [PATCH v2 5/8] drivers/perf: hisi: Relax the event number check of v2 PMUs Yicong Yang
2025-03-21 11:14 ` Jonathan Cameron
2025-03-21 7:38 ` [PATCH v2 6/8] drivers/perf: hisi: Support PMUs with no interrupt Yicong Yang
2025-03-21 7:38 ` [PATCH v2 7/8] drivers/perf: hisi: Add support for HiSilicon NoC PMU Yicong Yang
2025-03-21 7:38 ` [PATCH v2 8/8] drivers/perf: hisi: Add support for HiSilicon MN PMU driver Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250321111318.0000455e@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=hejunhao3@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=prime.zeng@hisilicon.com \
--cc=wangyushan12@huawei.com \
--cc=will@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.