All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Vincent Donnefort <vdonnefort@google.com>,
	Huang Yiwei <quic_hyiwei@quicinc.com>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: fix build without CONFIG_MODULES
Date: Fri, 21 Mar 2025 12:35:50 -0400	[thread overview]
Message-ID: <20250321123550.31efa14e@batman.local.home> (raw)
In-Reply-To: <20250314155052.4170214-1-arnd@kernel.org>

On Fri, 14 Mar 2025 16:50:49 +0100
Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> The tracing code fails to build when CONFIG_MODULES is disabled:
> 
> kernel/trace/trace.c: In function 'save_mod':
> kernel/trace/trace.c:6041:45: error: invalid use of undefined type 'struct module'
>  6041 |         entry->mod_addr = (unsigned long)mod->mem[MOD_TEXT].base;
>       |                                             ^~
> 
> The problem here is that 'struct module' is not defined in this configuration.
> 
> Enclose the functions in another #ifdef, just like other parts of this file
> already are.
> 
> Fixes: dca91c1c5468 ("tracing: Have persistent trace instances save module addresses")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Thanks, but Masami already sent one fix where I commented on and he
then sent an update:

  https://lore.kernel.org/all/174188321162.3845006.12665585959241736399.stgit@mhiramat.tok.corp.google.com/

and the update:

  https://lore.kernel.org/all/174230515367.2909896.8132122175220657625.stgit@mhiramat.tok.corp.google.com/

-- Steve

      reply	other threads:[~2025-03-21 16:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 15:50 [PATCH] tracing: fix build without CONFIG_MODULES Arnd Bergmann
2025-03-21 16:35 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250321123550.31efa14e@batman.local.home \
    --to=rostedt@goodmis.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=quic_hyiwei@quicinc.com \
    --cc=vdonnefort@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.