From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Daniel Golle <daniel@makrotopia.org>,
Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, lvc-patches@linuxtesting.org
Subject: Re: [PATCH] wifi: rt2x00: remove weird self-assignment in rt2800_loft_search()
Date: Sat, 22 Mar 2025 14:18:27 +0100 [thread overview]
Message-ID: <20250322131827.GA94848@wp.pl> (raw)
In-Reply-To: <20250321134256.821596-1-dmantipov@yandex.ru>
On Fri, Mar 21, 2025 at 04:42:56PM +0300, Dmitry Antipov wrote:
> Remove weird self-assignment in 'rt2800_loft_search()' assuming
> that it was just a typo. Compile tested only.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
> ---
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> index e5f553a1ea24..b7ea606bda08 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -9393,7 +9393,7 @@ static void rt2800_loft_search(struct rt2x00_dev *rt2x00dev, u8 ch_idx,
> p0, p1, pf, idx0, idx1, ibit);
>
> if (bidx != 5 && pf <= p0 && pf < p1) {
> - idxf[iorq] = idxf[iorq];
> + /* no need to adjust idxf[] */;
> } else if (p0 < p1) {
> pf = p0;
> idxf[iorq] = idx0 & 0x3F;
> --
> 2.49.0
>
prev parent reply other threads:[~2025-03-22 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 13:42 [PATCH] wifi: rt2x00: remove weird self-assignment in rt2800_loft_search() Dmitry Antipov
2025-03-22 13:18 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250322131827.GA94848@wp.pl \
--to=stf_xl@wp.pl \
--cc=daniel@makrotopia.org \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-patches@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.