From: Andrew Jones <ajones@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 2/6] lib: sbi: sse: Fix format string for event invalid state
Date: Mon, 24 Mar 2025 17:39:52 +0100 [thread overview]
Message-ID: <20250324-1d656e6ccf6562b1980794ae@orel> (raw)
In-Reply-To: <20250317105426.631243-3-cleger@rivosinc.com>
On Mon, Mar 17, 2025 at 11:54:20AM +0100, Cl?ment L?ger wrote:
> Add a missing newline and modify the display value of the event id to
> use hex representation.
>
> Signed-off-by: Cl?ment L?ger <cleger@rivosinc.com>
> ---
> lib/sbi/sbi_sse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c
> index 4722ddc4..a30fad54 100644
> --- a/lib/sbi/sbi_sse.c
> +++ b/lib/sbi/sbi_sse.c
> @@ -1268,7 +1268,7 @@ void sbi_sse_exit(struct sbi_scratch *scratch)
> goto skip;
>
> if (sse_event_state(e) > SBI_SSE_STATE_REGISTERED) {
> - sbi_printf("Event %d in invalid state at exit",
> + sbi_printf("Event 0x%x in invalid state at exit\n",
> info->event_id);
> sse_event_set_state(e, SBI_SSE_STATE_UNUSED);
> }
> --
> 2.47.2
>
I'm not sure we want the print statement, but if we do, then
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
next prev parent reply other threads:[~2025-03-24 16:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 10:54 [PATCH 0/6] lib: sbi: sse: spec update and fixes Clément Léger
2025-03-17 10:54 ` [PATCH 1/6] lib: sbi: sse: Update SSE event ids Clément Léger
2025-03-24 16:15 ` Andrew Jones
2025-03-17 10:54 ` [PATCH 2/6] lib: sbi: sse: Fix format string for event invalid state Clément Léger
2025-03-24 16:39 ` Andrew Jones [this message]
2025-03-24 16:41 ` Clément Léger
2025-03-17 10:54 ` [PATCH 3/6] lib: sbi: sse: Return SBI_EDENIED for read only parameters Clément Léger
2025-03-24 17:01 ` Andrew Jones
2025-03-24 17:02 ` Clément Léger
2025-03-17 10:54 ` [PATCH 4/6] lib: sbi: sse: Rename STATUS* interrupted flags to SSTATUS* Clément Léger
2025-03-24 17:03 ` Andrew Jones
2025-03-17 10:54 ` [PATCH 5/6] lib: sbi: sse: Add support for SSTATUS.SPELP Clément Léger
2025-03-24 17:08 ` Andrew Jones
2025-03-17 10:54 ` [PATCH 6/6] lib: sbi: sse: Add support for SSTATUS.SDT Clément Léger
2025-03-24 17:46 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324-1d656e6ccf6562b1980794ae@orel \
--to=ajones@ventanamicro.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.