Re: [PATCH net] rtnetlink: Allocate vfinfo size for VF GUIDs when supported

[Jakub Kicinski <kuba@kernel.org>]

On Thu, 20 Mar 2025 15:11:50 +0000 Simon Horman wrote:
> Perhaps I'm over thinking things here,
> perhaps the following is easier on the eyes?
> 
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index d1e559fce918..60fac848e092 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1151,6 +1151,9 @@ static inline int rtnl_vfinfo_size(const struct net_device *dev,
>  			 nla_total_size(sizeof(struct ifla_vf_link_state)) +
>  			 nla_total_size(sizeof(struct ifla_vf_rss_query_en)) +
>  			 nla_total_size(sizeof(struct ifla_vf_trust)));
> +		if (dev->netdev_ops->ndo_get_vf_guid)
> +			size += num_vfs * 2 *
> +				nla_total_size(sizeof(struct ifla_vf_guid));
>  		if (~ext_filter_mask & RTEXT_FILTER_SKIP_STATS) {
>  			size += num_vfs *
>  				(nla_total_size(0) + /* nest IFLA_VF_STATS */

Yes, please
-- 
pw-bot: cr