From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
Shuah Khan <shuah@kernel.org>, <linux-kselftest@vger.kernel.org>,
Nimrod Oren <noren@nvidia.com>
Subject: Re: [PATCH net-next] selftests: drv-net: rss_input_xfrm: Check test prerequisites before running
Date: Mon, 24 Mar 2025 10:19:03 -0700 [thread overview]
Message-ID: <20250324101903.05e5ceeb@kernel.org> (raw)
In-Reply-To: <20250317123149.364565-1-gal@nvidia.com>
On Mon, 17 Mar 2025 14:31:49 +0200 Gal Pressman wrote:
> + try:
> + cmd("hash socat", host=cfg.remote)
> + except CmdExitFailure:
> + raise KsftSkipEx("socat not installed on remote")
I'm not familiar with "hash", would using
cfg.require_cmd("socat", remote=True)
work? IOW we do have a helper for this sort of checking.
next prev parent reply other threads:[~2025-03-24 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 12:31 [PATCH net-next] selftests: drv-net: rss_input_xfrm: Check test prerequisites before running Gal Pressman
2025-03-20 14:44 ` Simon Horman
2025-03-24 17:19 ` Jakub Kicinski [this message]
2025-03-24 17:53 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324101903.05e5ceeb@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.