From: Jakub Kicinski <kuba@kernel.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: linux-usb@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew+netdev@lunn.ch>
Subject: Re: [PATCH v2 net-next] rndis_host: Flag RNDIS modems as WWAN devices
Date: Mon, 24 Mar 2025 11:26:11 -0700 [thread overview]
Message-ID: <20250324112611.0eb6fdc3@kernel.org> (raw)
In-Reply-To: <20250317150739.2986057-1-lkundrak@v3.sk>
On Mon, 17 Mar 2025 16:07:37 +0100 Lubomir Rintel wrote:
> Set FLAG_WWAN instead of FLAG_ETHERNET for RNDIS interfaces on Mobile
> Broadband Modems, as opposed to regular Ethernet adapters.
>
> Otherwise NetworkManager gets confused, misjudges the device type,
> and wouldn't know it should connect a modem to get the device to work.
> What would be the result depends on ModemManager version -- older
> ModemManager would end up disconnecting a device after an unsuccessful
> probe attempt (if it connected without needing to unlock a SIM), while
> a newer one might spawn a separate PPP connection over a tty interface
> instead, resulting in a general confusion and no end of chaos.
>
> The only way to get this work reliably is to fix the device type
> and have good enough version ModemManager (or equivalent).
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> Fixes: 475ddf05ce2d ("rndis_host: Flag RNDIS modems as WWAN devices")
This should point to the commit you're fixing. Judging purely by the
touched lines perhaps 63ba395cd7a5 ("rndis_host: support Novatel Verizon
USB730L") ?
--
pw-bot: cr
prev parent reply other threads:[~2025-03-24 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 15:07 [PATCH v2 net-next] rndis_host: Flag RNDIS modems as WWAN devices Lubomir Rintel
2025-03-24 18:26 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250324112611.0eb6fdc3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.