Re: [meta-arago][master][PATCH 7/8] packagegroup-arago-gst: Wrap various packages in a compliant manner

[Denys Dmytriyenko <denis@denix.org>]

On Thu, Mar 20, 2025 at 01:20:40PM -0500, Ryan Eatmon via lists.yoctoproject.org wrote:
> yocto-check-layer does not load the conf/distro/arago.conf file during
> its execution.  This means that the LICENSE_FLAGS_ACCEPTED variable is not
> set according to what we are willing to accept.
> 
> If a packagegroup is trying to include a recipe that is marked as being
> "commercial" and the LICENSE_FLAGS_ACCEPTED is not set, then yocto-check-layer
> fails.
> 
> The solution is to wrap the inclusion of these recipes in the packagegroup
> in a complaint manner.  Only if the DISTRO_OVERRIDE says that this is an
> "arago" build, should the package be included and this under the direction
> of the LICENSE_FLAGS_ACCEPTED variable.
> 
> Signed-off-by: Ryan Eatmon <reatmon@ti.com>
> ---
>  .../recipes-core/packagegroups/packagegroup-arago-gst.bb       | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb
> index 0aee4773..f5832109 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb
> @@ -14,9 +14,10 @@ GSTREAMER_DEPS = " \
>      gstreamer1.0-plugins-base-meta \
>      gstreamer1.0-plugins-good-meta \
>      gstreamer1.0-plugins-bad-meta \
> -    gstreamer1.0-libav \
>  "
>  
> +GSTREAMER_DEPS:arago += "gstreamer1.0-libav"

It's not recommended to mix overrides (:arago) and appending operands (+=)

GSTREAMER_DEPS:append:arago = " gstreamer1.0-libav"


>  #    gstreamer1.0-plugins-hevc 
>  GSTREAMER_DEPS:append:dra7xx = " \
>  "
> -- 
> 2.17.1