From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD1082561D7; Tue, 25 Mar 2025 12:32:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905944; cv=none; b=D8nwjECZcr+3UmdnF76Tt8HFQeo+QP3JTT+r5SVVHn8YHBsR63KSet1mkqLIQmvUsFUi8OoVNa8rKpw+C6HcbGIXTde9m9lW+LnBlpbwLhdgxnWQ1WNBQF/1FgXntO62sdIVEKmva5dxxMZglXmg5fCKrxJPak5wWzKkLlPBUNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905944; c=relaxed/simple; bh=NexElz9PouWnG0mwfnn4F9+psSH7gDNxpdBrKgJFqq4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DBkaBe7zMFgBGMZ5/EWDPBkSvlJWTnVF+Um63eXJP66g4H20sQ3LFGeinp44ZOSzfojxS54Apw8WJGXOs+onI8hHsow3NIZoCEVwdFMzqJbguvViYD1klxND3nIWyayZtqmdEI9h6x4MBfgygHocKIdbncdUC8tZv/gFjqadcP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cZFjQI3Y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cZFjQI3Y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D92A4C4CEE4; Tue, 25 Mar 2025 12:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1742905944; bh=NexElz9PouWnG0mwfnn4F9+psSH7gDNxpdBrKgJFqq4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cZFjQI3YqkJR09HclH4OkjC2zj6u9YUekDM1oaG6Nz+xhfK640u8MoEBT5q8F3Esc fM6TTfIFxDJhDnc1AkwF5whKgRhGCdap+478g6lfpduH5LUJbFnHL8vcQ14O3vAEA4 5Ha7yTcOX1aMcgH6iwX9XEIi4AlTU3faAdVJ23Dc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yongjian Sun , Chuck Lever , Christian Brauner , Sasha Levin Subject: [PATCH 6.13 049/119] libfs: Fix duplicate directory entry in offset_dir_lookup Date: Tue, 25 Mar 2025 08:21:47 -0400 Message-ID: <20250325122150.308146817@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250325122149.058346343@linuxfoundation.org> References: <20250325122149.058346343@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.13-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yongjian Sun [ Upstream commit f70681e9e6066ab7b102e6b46a336a8ed67812ae ] There is an issue in the kernel: In tmpfs, when using the "ls" command to list the contents of a directory with a large number of files, glibc performs the getdents call in multiple rounds. If a concurrent unlink occurs between these getdents calls, it may lead to duplicate directory entries in the ls output. One possible reproduction scenario is as follows: Create 1026 files and execute ls and rm concurrently: for i in {1..1026}; do echo "This is file $i" > /tmp/dir/file$i done ls /tmp/dir rm /tmp/dir/file4 ->getdents(file1026-file5) ->unlink(file4) ->getdents(file5,file3,file2,file1) It is expected that the second getdents call to return file3 through file1, but instead it returns an extra file5. The root cause of this problem is in the offset_dir_lookup function. It uses mas_find to determine the starting position for the current getdents call. Since mas_find locates the first position that is greater than or equal to mas->index, when file4 is deleted, it ends up returning file5. It can be fixed by replacing mas_find with mas_find_rev, which finds the first position that is less than or equal to mas->index. Fixes: b9b588f22a0c ("libfs: Use d_children list to iterate simple_offset directories") Signed-off-by: Yongjian Sun Link: https://lore.kernel.org/r/20250320034417.555810-1-sunyongjian@huaweicloud.com Reviewed-by: Chuck Lever Signed-off-by: Christian Brauner Signed-off-by: Sasha Levin --- fs/libfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/libfs.c b/fs/libfs.c index 279442b1fe968..54822b559827c 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -496,7 +496,7 @@ offset_dir_lookup(struct dentry *parent, loff_t offset) found = find_positive_dentry(parent, NULL, false); else { rcu_read_lock(); - child = mas_find(&mas, DIR_OFFSET_MAX); + child = mas_find_rev(&mas, DIR_OFFSET_MIN); found = find_positive_dentry(parent, child, false); rcu_read_unlock(); } -- 2.39.5