From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8F0C25D55A; Tue, 25 Mar 2025 12:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742906327; cv=none; b=ebGOUJ2ipz7gkarXhKciCsT/WPZK2kKRB0PZIfCnm9RUWsqjBIozh3+yn50EZpuEv2GsEJxeIayEAOZwWxov4MmC8Pfe7g6r9egjkF0lN6iIfJGtik3fAKxb9ET2xfapnqmWmcCXlH0Qr9nhkMZFKrwl9M3vgI9Kr9YnfM26TfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742906327; c=relaxed/simple; bh=J8eviI9mqACx2HUrQfjPPm7/PS2OQl1jKgl2gPlIK8g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m9dmNdksEbk6Jp0pjNvtXUUQMnsDJG7XYaXHMLlsYhYT7GO6CMWBr2UC5XjXwufQAQLl5bGFP1L5mf4JiAjG+NwyYLzv0WrU3gIdZndk3UAdoQbcvFhGFJwz/OrfwVdVvnhYIyrGRU7qFhn/D9UUMvH+fjpkIAbAOX7qIAXlYWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jIgY40fo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jIgY40fo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36757C4CEE9; Tue, 25 Mar 2025 12:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1742906327; bh=J8eviI9mqACx2HUrQfjPPm7/PS2OQl1jKgl2gPlIK8g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jIgY40fogeSY+yf1SjPBovyZC7rLUtgymdRgHILByf4Cn+v0P1Mw2RC1o8exxHAp+ +FMvwWEjGBhIHsW9W+ERVf62DLAl9KdTP/JFTj7655Vd/D+8oTj4554h05mQY7przu 6R2vvCXZQqWkJHplCxEmfFOAssM7e4Yz7rSZ4fCk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Frank Li , Haibo Chen , Marc Kleine-Budde Subject: [PATCH 6.12 058/116] can: flexcan: disable transceiver during system PM Date: Tue, 25 Mar 2025 08:22:25 -0400 Message-ID: <20250325122150.693559462@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250325122149.207086105@linuxfoundation.org> References: <20250325122149.207086105@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haibo Chen commit 5a19143124be42900b3fbc9ada3c919632eb45eb upstream. During system PM, if no wakeup requirement, disable transceiver to save power. Fixes: 4de349e786a3 ("can: flexcan: fix resume function") Cc: stable@vger.kernel.org Reviewed-by: Frank Li Signed-off-by: Haibo Chen Link: https://patch.msgid.link/20250314110145.899179-2-haibo.chen@nxp.com [mkl: add newlines] Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/flexcan/flexcan-core.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) --- a/drivers/net/can/flexcan/flexcan-core.c +++ b/drivers/net/can/flexcan/flexcan-core.c @@ -2260,6 +2260,10 @@ static int __maybe_unused flexcan_suspen flexcan_chip_interrupts_disable(dev); + err = flexcan_transceiver_disable(priv); + if (err) + return err; + err = pinctrl_pm_select_sleep_state(device); if (err) return err; @@ -2292,10 +2296,16 @@ static int __maybe_unused flexcan_resume if (err) return err; - err = flexcan_chip_start(dev); + err = flexcan_transceiver_enable(priv); if (err) return err; + err = flexcan_chip_start(dev); + if (err) { + flexcan_transceiver_disable(priv); + return err; + } + flexcan_chip_interrupts_enable(dev); }