Re: Remove useless code in example [libgpiod]

[Kent Gibson <warthog618@gmail.com>]

On Mon, Mar 24, 2025 at 11:23:17PM -0400, Rostyslav Lobov wrote:
> Hello, I noticed that `libgpiod/examples/reconfigure_input_to_output.c`
> has some useless declaration `struct gpiod_request_config *req_cfg =
> NULL;` and later free `gpiod_request_config_free(req_cfg);` of the
> variable which is never used...
> So I'm attaching a fix patch.
> Rostyslav Lobov

> diff --git a/examples/reconfigure_input_to_output.c b/examples/reconfigure_input_to_output.c
> index 451bb0e..734a99c 100644
> --- a/examples/reconfigure_input_to_output.c
> +++ b/examples/reconfigure_input_to_output.c
> @@ -71,7 +71,6 @@ static int reconfigure_as_output_line(struct gpiod_line_request *request,
>  				      unsigned int offset,
>  				      enum gpiod_line_value value)
>  {
> -	struct gpiod_request_config *req_cfg = NULL;
>  	struct gpiod_line_settings *settings;
>  	struct gpiod_line_config *line_cfg;
>  	int ret = -1;
> @@ -95,8 +94,6 @@ static int reconfigure_as_output_line(struct gpiod_line_request *request,
>
>  	ret = gpiod_line_request_reconfigure_lines(request, line_cfg);
>
> -	gpiod_request_config_free(req_cfg);
> -
>  free_line_config:
>  	gpiod_line_config_free(line_cfg);
>

The patch makes sense, that code looks like a leftover from a cut-and-paste,
but please re-submit as per the CONTRIBUTING section of the README.

Cheers,
Kent.