From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Pedro Tammela <pctammela@mojatatu.com>
Cc: Jonathan Lennox <jonathan.lennox42@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Jonathan Lennox <jonathan.lennox@8x8.com>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next] tc-tests: Update tc police action tests for tc buffer size rounding fixes.
Date: Wed, 26 Mar 2025 04:39:06 -0700 [thread overview]
Message-ID: <20250326043906.2ab47b20@kernel.org> (raw)
In-Reply-To: <CAM0EoMnmWXRWWEwanzTOZ_dLBoeCr7UM4DYwFkDmLfS93ijM2g@mail.gmail.com>
On Tue, 11 Mar 2025 07:15:26 -0400 Jamal Hadi Salim wrote:
> > On Tue, 11 Mar 2025 10:16:14 +0100 Paolo Abeni wrote:
> > > AFAICS this fix will break the tests when running all version of
> > > iproute2 except the upcoming one. I think this is not good enough; you
> > > should detect the tc tool version and update expected output accordingly.
> > >
> > > If that is not possible, I think it would be better to simply revert the
> > > TC commit.
> >
> > Alternatively since it's a regex match, maybe we could accept both?
> >
> > - "matchPattern": "action order [0-9]*: police 0x1 rate 7Mbit burst 1024Kb mtu 2Kb action reclassify",
> > + "matchPattern": "action order [0-9]*: police 0x1 rate 7Mbit burst (1Mb|1024Kb) mtu 2Kb action reclassify",
> >
> > ? Not sure which option is most "correct" from TDC's perspective..
>
> It should work. Paolo's suggestion is also reasonable.
Sorry for the ping but where are we with this? TDC has been "red" for
the last 3 weeks, would be really neat to get a clear run before we
ship the net-next tree to Linus :(
next prev parent reply other threads:[~2025-03-26 11:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 21:16 [PATCH iproute2] tc: Fix rounding in tc_calc_xmittime and tc_calc_xmitsize Jonathan Lennox
2025-02-17 6:14 ` Stephen Hemminger
2025-02-18 20:10 ` Jonathan Lennox
2025-02-18 20:10 ` [PATCH iproute2 v2] " Jonathan Lennox
2025-02-24 3:06 ` David Ahern
2025-02-24 16:36 ` Jonathan Lennox
2025-02-24 16:58 ` David Ahern
2025-02-24 18:42 ` [PATCH iproute2 v3] " Jonathan Lennox
2025-02-26 16:06 ` David Ahern
2025-02-26 18:55 ` Jonathan Lennox
2025-02-26 18:53 ` Jonathan Lennox
2025-02-28 15:50 ` patchwork-bot+netdevbpf
2025-03-03 18:39 ` Pedro Tammela
2025-03-03 19:43 ` Jonathan Lennox
2025-03-03 20:35 ` Pedro Tammela
2025-03-03 22:13 ` Jonathan Lennox
2025-03-04 17:51 ` Pedro Tammela
2025-03-04 19:38 ` [PATCH net-next] tc-tests: Update tc police action tests for tc buffer size rounding fixes Jonathan Lennox
2025-03-11 9:16 ` Paolo Abeni
2025-03-11 9:49 ` Jakub Kicinski
2025-03-11 11:15 ` Jamal Hadi Salim
2025-03-12 17:42 ` Jonathan Lennox
2025-03-26 11:39 ` Jakub Kicinski [this message]
2025-03-26 19:04 ` Pedro Tammela
2025-03-26 19:07 ` Pedro Tammela
2025-03-12 16:47 ` [PATCH net-next v2] " Jonathan Lennox
2025-03-12 17:48 ` [PATCH net-next v3] " Jonathan Lennox
2025-03-12 17:48 ` Jonathan Lennox
2025-03-19 17:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250326043906.2ab47b20@kernel.org \
--to=kuba@kernel.org \
--cc=dsahern@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=jonathan.lennox42@gmail.com \
--cc=jonathan.lennox@8x8.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.