From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [android-common:android14-6.1-2024-05 13/13] net/bridge/br_input.c:250:2: error: implicit declaration of function 'nf_hook_state_init'; did you mean 'ethtool_stats_init'?
Date: Wed, 26 Mar 2025 09:34:01 +0800 [thread overview]
Message-ID: <202503260955.2YCdJnUU-lkp@intel.com> (raw)
Hi Norihiko,
FYI, the error/warning still remains.
tree: https://android.googlesource.com/kernel/common android14-6.1-2024-05
head: 21c4eb1762f0c7d1daf1a88227bd5f101bcfdf78
commit: bc4d82ee40515f0c770b28d0dc4fa532a2b1850e [13/13] ANDROID: KMI workaround for CONFIG_NETFILTER_FAMILY_BRIDGE
config: arm64-randconfig-003-20250326 (https://download.01.org/0day-ci/archive/20250326/202503260955.2YCdJnUU-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250326/202503260955.2YCdJnUU-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503260955.2YCdJnUU-lkp@intel.com/
All errors (new ones prefixed by >>):
net/bridge/br_input.c: In function 'nf_hook_bridge_pre':
>> net/bridge/br_input.c:250:2: error: implicit declaration of function 'nf_hook_state_init'; did you mean 'ethtool_stats_init'? [-Werror=implicit-function-declaration]
nf_hook_state_init(&state, NF_BR_PRE_ROUTING,
^~~~~~~~~~~~~~~~~~
ethtool_stats_init
>> net/bridge/br_input.c:255:13: error: implicit declaration of function 'nf_hook_entry_hookfn' [-Werror=implicit-function-declaration]
verdict = nf_hook_entry_hookfn(&e->hooks[i], skb, &state);
^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for PHYLINK
Depends on [n]: NETDEVICES [=n]
Selected by [y]:
- GKI_HIDDEN_ETHERNET_CONFIGS [=y]
WARNING: unmet direct dependencies detected for HVC_DRIVER
Depends on [n]: TTY [=n]
Selected by [y]:
- GKI_HIDDEN_VIRTUAL_CONFIGS [=y]
WARNING: unmet direct dependencies detected for NETFILTER_FAMILY_BRIDGE
Depends on [n]: NET [=y] && INET [=y] && NETFILTER [=n]
Selected by [y]:
- GKI_HIDDEN_NET_CONFIGS [=y]
WARNING: unmet direct dependencies detected for VIDEO_V4L2_SUBDEV_API
Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=n] && MEDIA_CONTROLLER [=y]
Selected by [y]:
- GKI_HIDDEN_MEDIA_CONFIGS [=y]
WARNING: unmet direct dependencies detected for SND_JACK
Depends on [n]: SOUND [=n] && !UML && SND [=n]
Selected by [y]:
- GKI_HIDDEN_SND_CONFIGS [=y]
WARNING: unmet direct dependencies detected for SND_VMASTER
Depends on [n]: SOUND [=n] && !UML && SND [=n]
Selected by [y]:
- GKI_HIDDEN_SND_CONFIGS [=y]
WARNING: unmet direct dependencies detected for CAN_RX_OFFLOAD
Depends on [n]: NETDEVICES [=n] && CAN_DEV [=n] && CAN_NETLINK [=n]
Selected by [y]:
- GKI_HIDDEN_MCP251XFD_CONFIGS [=y]
WARNING: unmet direct dependencies detected for SND_PCM_IEC958
Depends on [n]: SOUND [=n] && !UML && SND [=n]
Selected by [y]:
- GKI_HIDDEN_SND_SOC_CONFIGS [=y]
WARNING: unmet direct dependencies detected for SND_JACK_INPUT_DEV
Depends on [n]: SOUND [=n] && !UML && SND [=n] && SND_JACK [=y]
Selected by [y]:
- GKI_HIDDEN_SND_CONFIGS [=y]
WARNING: unmet direct dependencies detected for SND_PCM_ELD
Depends on [n]: SOUND [=n] && !UML && SND [=n]
Selected by [y]:
- GKI_HIDDEN_SND_CONFIGS [=y]
vim +250 net/bridge/br_input.c
971502d77faa50 Florian Westphal 2019-04-11 245
bc4d82ee40515f Norihiko Hama 2023-12-15 246 e = rcu_dereference(get_nf_hooks_bridge(net)[NF_BR_PRE_ROUTING]);
971502d77faa50 Florian Westphal 2019-04-11 247 if (!e)
971502d77faa50 Florian Westphal 2019-04-11 248 goto frame_finish;
971502d77faa50 Florian Westphal 2019-04-11 249
971502d77faa50 Florian Westphal 2019-04-11 @250 nf_hook_state_init(&state, NF_BR_PRE_ROUTING,
971502d77faa50 Florian Westphal 2019-04-11 251 NFPROTO_BRIDGE, skb->dev, NULL, NULL,
971502d77faa50 Florian Westphal 2019-04-11 252 net, br_handle_frame_finish);
971502d77faa50 Florian Westphal 2019-04-11 253
971502d77faa50 Florian Westphal 2019-04-11 254 for (i = 0; i < e->num_hook_entries; i++) {
971502d77faa50 Florian Westphal 2019-04-11 @255 verdict = nf_hook_entry_hookfn(&e->hooks[i], skb, &state);
971502d77faa50 Florian Westphal 2019-04-11 256 switch (verdict & NF_VERDICT_MASK) {
971502d77faa50 Florian Westphal 2019-04-11 257 case NF_ACCEPT:
223fd0adfa8af3 Florian Westphal 2019-04-11 258 if (BR_INPUT_SKB_CB(skb)->br_netfilter_broute) {
223fd0adfa8af3 Florian Westphal 2019-04-11 259 *pskb = skb;
223fd0adfa8af3 Florian Westphal 2019-04-11 260 return RX_HANDLER_PASS;
223fd0adfa8af3 Florian Westphal 2019-04-11 261 }
971502d77faa50 Florian Westphal 2019-04-11 262 break;
971502d77faa50 Florian Westphal 2019-04-11 263 case NF_DROP:
971502d77faa50 Florian Westphal 2019-04-11 264 kfree_skb(skb);
971502d77faa50 Florian Westphal 2019-04-11 265 return RX_HANDLER_CONSUMED;
971502d77faa50 Florian Westphal 2019-04-11 266 case NF_QUEUE:
0d9cb300acad29 Florian Westphal 2019-07-02 267 ret = nf_queue(skb, &state, i, verdict);
971502d77faa50 Florian Westphal 2019-04-11 268 if (ret == 1)
971502d77faa50 Florian Westphal 2019-04-11 269 continue;
971502d77faa50 Florian Westphal 2019-04-11 270 return RX_HANDLER_CONSUMED;
971502d77faa50 Florian Westphal 2019-04-11 271 default: /* STOLEN */
971502d77faa50 Florian Westphal 2019-04-11 272 return RX_HANDLER_CONSUMED;
971502d77faa50 Florian Westphal 2019-04-11 273 }
971502d77faa50 Florian Westphal 2019-04-11 274 }
971502d77faa50 Florian Westphal 2019-04-11 275 frame_finish:
971502d77faa50 Florian Westphal 2019-04-11 276 net = dev_net(skb->dev);
971502d77faa50 Florian Westphal 2019-04-11 277 br_handle_frame_finish(net, NULL, skb);
971502d77faa50 Florian Westphal 2019-04-11 278 #else
971502d77faa50 Florian Westphal 2019-04-11 279 br_handle_frame_finish(dev_net(skb->dev), NULL, skb);
971502d77faa50 Florian Westphal 2019-04-11 280 #endif
971502d77faa50 Florian Westphal 2019-04-11 281 return RX_HANDLER_CONSUMED;
971502d77faa50 Florian Westphal 2019-04-11 282 }
971502d77faa50 Florian Westphal 2019-04-11 283
:::::: The code at line 250 was first introduced by commit
:::::: 971502d77faa50a37c89bc6d172450294ad9a5fd bridge: netfilter: unroll NF_HOOK helper in bridge input path
:::::: TO: Florian Westphal <fw@strlen.de>
:::::: CC: Pablo Neira Ayuso <pablo@netfilter.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-03-26 1:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202503260955.2YCdJnUU-lkp@intel.com \
--to=lkp@intel.com \
--cc=cros-kernel-buildreports@googlegroups.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.