All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Cc: Arshad Mehmood <arshad.mehmood@intel.com>,
	Chris Wilson <chris.p.wilson@linux.intel.com>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	Andi Shyti <andi.shyti@kernel.org>
Subject: [PATCH v2 1/6] drm/i915: Add the FIRST_CCS() helper
Date: Thu, 27 Mar 2025 00:40:00 +0100	[thread overview]
Message-ID: <20250326234005.1574688-2-andi.shyti@linux.intel.com> (raw)
In-Reply-To: <20250326234005.1574688-1-andi.shyti@linux.intel.com>

From: Andi Shyti <andi.shyti@intel.com>

Some GPUs, like DG2, can host more than one CCS engine. Some
workarounds or enablements need to happen only once for all the
engines in the GT—for example, on the engine with the lowest
instance.

The FIRST_CCS() helper first checks if the engine is a Compute
engine, and then whether it's the one with the lowest instance.

Signed-off-by: Andi Shyti <andi.shyti@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 54538b6f85df..5cb501393c4b 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -619,6 +619,9 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
 #define CCS_MASK(gt) \
 	ENGINE_INSTANCES_MASK(gt, CCS0, I915_MAX_CCS)
 
+#define FIRST_CCS(e__) \
+	(CCS_MASK(e__->gt) && (__ffs(CCS_MASK(e__->gt)) == e__->instance))
+
 #define HAS_MEDIA_RATIO_MODE(i915) (INTEL_INFO(i915)->has_media_ratio_mode)
 
 /*
-- 
2.47.2


  reply	other threads:[~2025-03-26 23:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26 23:39 [PATCH v2 0/6] Remove I915_ENGINE_FIRST_RENDER_COMPUTE Andi Shyti
2025-03-26 23:40 ` Andi Shyti [this message]
2025-03-27 10:42   ` [PATCH v2 1/6] drm/i915: Add the FIRST_CCS() helper Jani Nikula
2025-03-27 11:05     ` Andi Shyti
2025-03-26 23:40 ` [PATCH v2 2/6] drm/i915/gt: Move CCS workaround to the correct section Andi Shyti
2025-04-23 14:06   ` Lucas De Marchi
2025-03-26 23:40 ` [PATCH v2 3/6] drm/i915/gt: Remove FIRST_RENDER_COMPUTE in workaround Andi Shyti
2025-03-26 23:40 ` [PATCH v2 4/6] drm/i915/gt: Check for the first CCS instead of FIRST_RENDER_COMPUTE Andi Shyti
2025-03-26 23:40 ` [PATCH v2 5/6] drm/i915/gt/uc: Use FIRST_CCS() helper for one-time CCS operations Andi Shyti
2025-03-26 23:40 ` [PATCH v2 6/6] drm/i915/gt: Remove unused I915_ENGINE_FIRST_RENDER_COMPUTE flag Andi Shyti
2025-04-23 13:57   ` Lucas De Marchi
2025-03-27  0:13 ` ✗ Fi.CI.CHECKPATCH: warning for Remove I915_ENGINE_FIRST_RENDER_COMPUTE Patchwork
2025-03-27  0:14 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-03-27  3:13 ` ✓ i915.CI.BAT: success " Patchwork
2025-03-27  4:52 ` ✗ i915.CI.Full: failure " Patchwork
2025-04-23 13:54 ` [PATCH v2 0/6] " Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250326234005.1574688-2-andi.shyti@linux.intel.com \
    --to=andi.shyti@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=arshad.mehmood@intel.com \
    --cc=chris.p.wilson@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.