All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Tamir Duberstein" <tamird@gmail.com>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nicolas Schier" <nicolas@fjasle.eu>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Brendan Higgins" <brendan.higgins@linux.dev>,
	"David Gow" <davidgow@google.com>, "Rae Moar" <rmoar@google.com>,
	"Bjorn Helgaas" <helgaas@kernel.org>,
	"Luis Chamberlain" <mcgrof@kernel.org>,
	"Russ Weight" <russ.weight@linux.dev>,
	"Rob Herring" <robh@kernel.org>,
	"Saravana Kannan" <saravanak@google.com>,
	"Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v7 7/7] rust: enable `clippy::ref_as_ptr` lint
Date: Thu, 27 Mar 2025 08:22:14 +0800	[thread overview]
Message-ID: <202503270730.qlrkmZkU-lkp@intel.com> (raw)
In-Reply-To: <20250325-ptr-as-ptr-v7-7-87ab452147b9@gmail.com>

Hi Tamir,

kernel test robot noticed the following build errors:

[auto build test ERROR on 28bb48c4cb34f65a9aa602142e76e1426da31293]

url:    https://github.com/intel-lab-lkp/linux/commits/Tamir-Duberstein/rust-retain-pointer-mut-ness-in-container_of/20250326-081159
base:   28bb48c4cb34f65a9aa602142e76e1426da31293
patch link:    https://lore.kernel.org/r/20250325-ptr-as-ptr-v7-7-87ab452147b9%40gmail.com
patch subject: [PATCH v7 7/7] rust: enable `clippy::ref_as_ptr` lint
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20250327/202503270730.qlrkmZkU-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
rustc: rustc 1.78.0 (9b00956e5 2024-04-29)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250327/202503270730.qlrkmZkU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503270730.qlrkmZkU-lkp@intel.com/

All errors (new ones prefixed by >>):

   PATH=/opt/cross/clang-18/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
   INFO PATH=/opt/cross/rustc-1.78.0-bindgen-0.65.1/cargo/bin:/opt/cross/clang-18/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
   /usr/bin/timeout -k 100 12h /usr/bin/make KCFLAGS= -Wno-error=return-type -Wreturn-type -funsigned-char -Wundef W=1 --keep-going LLVM=1 -j32 -C source O=/kbuild/obj/consumer/x86_64-rhel-9.4-rust ARCH=x86_64 SHELL=/bin/bash rustfmtcheck
   make: Entering directory '/kbuild/src/consumer'
   make[1]: Entering directory '/kbuild/obj/consumer/x86_64-rhel-9.4-rust'
>> Diff in rust/kernel/uaccess.rs at line 356:
            // kernel pointer. This mirrors the logic on the C side that skips the check when the length
            // is a compile-time constant.
            let res = unsafe {
   -            bindings::_copy_to_user(
   -                self.ptr as *mut c_void,
   -                value.cast::<c_void>(),
   -                len,
   -            )
   +            bindings::_copy_to_user(self.ptr as *mut c_void, value.cast::<c_void>(), len)
            };
            if res != 0 {
                return Err(EFAULT);
>> Diff in rust/kernel/uaccess.rs at line 356:
            // kernel pointer. This mirrors the logic on the C side that skips the check when the length
            // is a compile-time constant.
            let res = unsafe {
   -            bindings::_copy_to_user(
   -                self.ptr as *mut c_void,
   -                value.cast::<c_void>(),
   -                len,
   -            )
   +            bindings::_copy_to_user(self.ptr as *mut c_void, value.cast::<c_void>(), len)
            };
            if res != 0 {
                return Err(EFAULT);
   make[2]: *** [Makefile:1817: rustfmt] Error 123
   make[2]: Target 'rustfmtcheck' not remade because of errors.
   make[1]: Leaving directory '/kbuild/obj/consumer/x86_64-rhel-9.4-rust'
   make[1]: *** [Makefile:251: __sub-make] Error 2
   make[1]: Target 'rustfmtcheck' not remade because of errors.
   make: *** [Makefile:251: __sub-make] Error 2
   make: Target 'rustfmtcheck' not remade because of errors.
   make: Leaving directory '/kbuild/src/consumer'

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2025-03-27  0:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 20:07 [PATCH v7 0/7] rust: reduce `as` casts, enable related lints Tamir Duberstein
2025-03-25 20:07 ` [PATCH v7 1/7] rust: retain pointer mut-ness in `container_of!` Tamir Duberstein
2025-03-25 20:07 ` [PATCH v7 2/7] rust: enable `clippy::ptr_as_ptr` lint Tamir Duberstein
2025-03-25 20:07 ` [PATCH v7 3/7] rust: enable `clippy::ptr_cast_constness` lint Tamir Duberstein
2025-03-25 20:07 ` [PATCH v7 4/7] rust: enable `clippy::as_ptr_cast_mut` lint Tamir Duberstein
2025-03-25 20:07 ` [PATCH v7 5/7] rust: enable `clippy::as_underscore` lint Tamir Duberstein
2025-03-25 20:07 ` [PATCH v7 6/7] rust: enable `clippy::cast_lossless` lint Tamir Duberstein
2025-03-25 20:07 ` [PATCH v7 7/7] rust: enable `clippy::ref_as_ptr` lint Tamir Duberstein
2025-03-25 22:11   ` Benno Lossin
2025-03-25 22:33     ` Tamir Duberstein
2025-03-25 22:40       ` Benno Lossin
2025-03-25 23:54         ` Tamir Duberstein
2025-03-26 10:30           ` Benno Lossin
2025-03-26 10:35             ` Tamir Duberstein
2025-03-26 16:43               ` Benno Lossin
2025-03-26 16:57                 ` Tamir Duberstein
2025-03-26 17:36                   ` Benno Lossin
2025-03-26 19:06                     ` Tamir Duberstein
2025-03-26 20:47                       ` Tamir Duberstein
2025-03-26 21:09                       ` Benno Lossin
2025-03-26 22:09                         ` Tamir Duberstein
2025-03-26 22:15                           ` Benno Lossin
2025-03-27 14:15                             ` Tamir Duberstein
2025-03-27 19:44                               ` Tamir Duberstein
2025-03-27 22:17                                 ` Benno Lossin
2025-03-27  0:22   ` kernel test robot [this message]
2025-03-25 20:22 ` [PATCH v7 0/7] rust: reduce `as` casts, enable related lints Miguel Ojeda
2025-03-25 23:31   ` Tamir Duberstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202503270730.qlrkmZkU-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=a.hindborg@kernel.org \
    --cc=abdiel.janulgue@gmail.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=brendan.higgins@linux.dev \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=davidgow@google.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=helgaas@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mripard@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rmoar@google.com \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=russ.weight@linux.dev \
    --cc=saravanak@google.com \
    --cc=tamird@gmail.com \
    --cc=tmgross@umich.edu \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.