All of lore.kernel.org
 help / color / mirror / Atom feed
From: gerben@altlinux.org
To: qemu-block@nongnu.org, kwolf@redhat.com, hreitz@redhat.com
Cc: qemu-devel@nongnu.org, sdl.qemu@linuxtesting.org,
	Denis Rastyogin <gerben@altlinux.org>
Subject: [PATCH 2/4] qemu-img: fix offset calculation in bench
Date: Thu, 27 Mar 2025 19:24:21 +0300	[thread overview]
Message-ID: <20250327162423.25154-3-gerben@altlinux.org> (raw)
In-Reply-To: <20250327162423.25154-1-gerben@altlinux.org>

From: Denis Rastyogin <gerben@altlinux.org>

This error was discovered by fuzzing qemu-img.

The current offset calculation leads to an EIO error
in block/block-backend.c: blk_check_byte_request():

 if (offset > len || len - offset < bytes) {
     return -EIO;
 }

This triggers the error message:
"qemu-img: Failed request: Input/output error".

Example of the issue:
 offset: 260076
 len: 260096
 bytes: 4096

This fix ensures that offset remains within a valid range.

Signed-off-by: Denis Rastyogin <gerben@altlinux.org>
---
 qemu-img.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-img.c b/qemu-img.c
index 2044c22a4c..71c9fe496f 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -4491,7 +4491,7 @@ static void bench_cb(void *opaque, int ret)
         if (b->image_size == 0) {
             b->offset = 0;
         } else {
-            b->offset %= b->image_size;
+            b->offset %= b->image_size - b->bufsize;
         }
         if (b->write) {
             acb = blk_aio_pwritev(b->blk, offset, b->qiov, 0, bench_cb, b);
-- 
2.42.2



  parent reply	other threads:[~2025-03-27 16:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-27 16:24 [PATCH 0/4] Fix qemu-img bench issues and improve checks gerben
2025-03-27 16:24 ` [PATCH 1/4] qemu-img: fix division by zero in bench_cb() for zero-sized gerben
2025-03-27 16:24 ` gerben [this message]
2025-04-25 16:04   ` [PATCH 2/4] qemu-img: fix offset calculation in bench Kevin Wolf
2025-03-27 16:24 ` [PATCH 3/4] qemu-img: prevent stack overflow in bench by using bottom half gerben
2025-04-25 16:08   ` Kevin Wolf
2025-03-27 16:24 ` [PATCH 4/4] qemu-img: improve queue depth validation in img_bench gerben
2025-04-25 16:10   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250327162423.25154-3-gerben@altlinux.org \
    --to=gerben@altlinux.org \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sdl.qemu@linuxtesting.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.