From: Eric Biggers <ebiggers@kernel.org>
To: David Binderman <dcb314@hotmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Ard Biesheuvel <ardb@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] arm64/crc-t10dif: fix use of out-of-scope array in crc_t10dif_arch()
Date: Thu, 27 Mar 2025 09:41:06 -0700 [thread overview]
Message-ID: <20250327164106.GB1425@sol.localdomain> (raw)
In-Reply-To: <AS8PR02MB10217FDBBC9DBA3A5B3C5F27B9CA12@AS8PR02MB10217.eurprd02.prod.outlook.com>
On Thu, Mar 27, 2025 at 07:58:51AM +0000, David Binderman wrote:
> Hello there Eric,
>
> >Fix a silly bug where an array was used outside of its scope.
>
> I am surprised your C compiler doesn't find this bug.
> gcc 14.2 onwards should be able to, but clang not.
>
> I will make an enhancement request in clang.
>
> Regards
>
> David Binderman
>
Neither gcc 14.2.0 nor clang 19.1.7 found it, unfortunately. And the code still
passed crc_kunit (even when run with have_pmull disabled so that the code is
reached).
- Eric
next prev parent reply other threads:[~2025-03-27 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 20:09 [PATCH] arm64/crc-t10dif: fix use of out-of-scope array in crc_t10dif_arch() Eric Biggers
2025-03-27 7:58 ` David Binderman
2025-03-27 16:41 ` Eric Biggers [this message]
2025-03-27 8:15 ` Ard Biesheuvel
2025-03-27 8:28 ` Ard Biesheuvel
2025-03-27 16:36 ` Eric Biggers
2025-03-27 16:41 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250327164106.GB1425@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=ardb@kernel.org \
--cc=dcb314@hotmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.