From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <i.abramov@mt-integration.ru>
Cc: <alex.aring@gmail.com>, <davem@davemloft.net>,
<edumazet@google.com>, <horms@kernel.org>, <kuba@kernel.org>,
<kuniyu@amazon.com>, <linux-kernel@vger.kernel.org>,
<linux-wpan@vger.kernel.org>, <lvc-project@linuxtesting.org>,
<miquel.raynal@bootlin.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <stefan@datenfreihafen.org>,
<syzbot+e0bd4e4815a910c0daa8@syzkaller.appspotmail.com>
Subject: Re: [PATCH 2/3] ieee802154: Avoid calling WARN_ON() on -ENOMEM in cfg802154_switch_netns()
Date: Thu, 27 Mar 2025 19:30:02 -0700 [thread overview]
Message-ID: <20250328023029.14249-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250328010427.735657-3-i.abramov@mt-integration.ru>
From: Ivan Abramov <i.abramov@mt-integration.ru>
Date: Fri, 28 Mar 2025 04:04:26 +0300
> It's pointless to call WARN_ON() in case of an allocation failure in
> dev_change_net_namespace() and device_rename(), since it only leads to
> useless splats caused by deliberate fault injections, so avoid it.
>
> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
>
> Fixes: 66e5c2672cd1 ("ieee802154: add netns support")
> Suggested-by: Kuniyuki Iwashima <kuniyu@amazon.com>
I suggested using net_warn_ratelimited() so this tag is not needed.
The patch itself looks good to me:
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
> Signed-off-by: Ivan Abramov <i.abramov@mt-integration.ru>
Reported-by: syzbot+e0bd4e4815a910c0daa8@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/000000000000f4a1b7061f9421de@google.com/#t
next prev parent reply other threads:[~2025-03-28 2:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 1:04 [PATCH 0/3] Avoid calling WARN_ON() on allocation failure in cfg802154_switch_netns() Ivan Abramov
2025-03-28 1:04 ` [PATCH 1/3] ieee802154: Restore initial state on failed device_rename() " Ivan Abramov
2025-03-28 1:04 ` [PATCH 2/3] ieee802154: Avoid calling WARN_ON() on -ENOMEM " Ivan Abramov
2025-03-28 2:30 ` Kuniyuki Iwashima [this message]
2025-03-31 9:40 ` Ivan Abramov
2025-03-28 1:04 ` [PATCH 3/3] ieee802154: Remove WARN_ON() in cfg802154_pernet_exit() Ivan Abramov
2025-03-28 2:35 ` [PATCH 0/3] Avoid calling WARN_ON() on allocation failure in cfg802154_switch_netns() Kuniyuki Iwashima
2025-03-28 8:29 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328023029.14249-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.abramov@mt-integration.ru \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefan@datenfreihafen.org \
--cc=syzbot+e0bd4e4815a910c0daa8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.