From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.au@gmail.com>
Subject: Re: [PATCH v2 1/2] drm: renesas: rz-du: Drop bpp variable from struct rzg2l_du_format_info
Date: Sun, 30 Mar 2025 14:12:29 +0300 [thread overview]
Message-ID: <20250330111229.GA8840@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20250330102357.56010-2-biju.das.jz@bp.renesas.com>
Hi Biju,
Thank you for the patch.
On Sun, Mar 30, 2025 at 11:23:52AM +0100, Biju Das wrote:
> Drop the unused variable bpp from struct rzg2l_du_format_info.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> v2:
> * New patch.
> ---
> drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 3 ---
> drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> index 90c6269ccd29..1a428ab3c424 100644
> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c
> @@ -38,19 +38,16 @@ static const struct rzg2l_du_format_info rzg2l_du_format_infos[] = {
> {
> .fourcc = DRM_FORMAT_XRGB8888,
> .v4l2 = V4L2_PIX_FMT_XBGR32,
> - .bpp = 32,
> .planes = 1,
> .hsub = 1,
> }, {
> .fourcc = DRM_FORMAT_ARGB8888,
> .v4l2 = V4L2_PIX_FMT_ABGR32,
> - .bpp = 32,
> .planes = 1,
> .hsub = 1,
> }, {
> .fourcc = DRM_FORMAT_RGB888,
> .v4l2 = V4L2_PIX_FMT_BGR24,
> - .bpp = 24,
> .planes = 1,
> .hsub = 1,
> }
> diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.h b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.h
> index 876e97cfbf45..e2c599f115c6 100644
> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.h
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.h
> @@ -23,7 +23,6 @@ struct sg_table;
> struct rzg2l_du_format_info {
> u32 fourcc;
> u32 v4l2;
> - unsigned int bpp;
> unsigned int planes;
> unsigned int hsub;
> };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2025-03-30 11:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-30 10:23 [PATCH v2 0/2] drm: renesas: Extend RZ/G2L KMS formats Biju Das
2025-03-30 10:23 ` [PATCH v2 1/2] drm: renesas: rz-du: Drop bpp variable from struct rzg2l_du_format_info Biju Das
2025-03-30 11:12 ` Laurent Pinchart [this message]
2025-04-03 9:21 ` Kieran Bingham
2025-03-30 10:23 ` [PATCH v2 2/2] drm: renesas: Extend RZ/G2L supported KMS formats Biju Das
2025-04-03 8:36 ` Tommaso Merciai
2025-04-07 6:40 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250330111229.GA8840@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.