All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: kernel test robot <lkp@intel.com>, Ingo Molnar <mingo@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Phil Auld <pauld@redhat.com>
Subject: [PATCH] sched/isolation: forbid CONFIG_CPU_ISOLATION without CONFIG_SMP
Date: Sun, 30 Mar 2025 15:49:55 +0200	[thread overview]
Message-ID: <20250330134955.GA7910@redhat.com> (raw)
In-Reply-To: <202503260646.lrUqD3j5-lkp@intel.com>

kernel/sched/isolation.c obviously makes no sense without CONFIG_SMP, but

	config CPU_ISOLATION
		bool "CPU isolation"
		depends on SMP || COMPILE_TEST

we currently have allows to create the pointless .config's which cause the
build failures.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202503260646.lrUqD3j5-lkp@intel.com/
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 init/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/Kconfig b/init/Kconfig
index 681f38ee68db..ab9b0c2c3d52 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -709,7 +709,7 @@ endmenu # "CPU/Task time and stats accounting"
 
 config CPU_ISOLATION
 	bool "CPU isolation"
-	depends on SMP || COMPILE_TEST
+	depends on SMP
 	default y
 	help
 	  Make sure that CPUs running critical tasks are not disturbed by
-- 
2.25.1.362.g51ebf55



  parent reply	other threads:[~2025-03-30 13:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 22:20 kernel/sched/isolation.c:50: undefined reference to `sched_numa_find_closest' kernel test robot
2025-03-26  9:35 ` Oleg Nesterov
2025-03-27 21:35   ` Ingo Molnar
2025-03-30 13:49 ` Oleg Nesterov [this message]
2025-03-30 19:23   ` [tip: sched/urgent] sched/isolation: Make CONFIG_CPU_ISOLATION depend on CONFIG_SMP tip-bot2 for Oleg Nesterov
2025-04-03 11:26   ` tip-bot2 for Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250330134955.GA7910@redhat.com \
    --to=oleg@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mingo@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pauld@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.