From: Nathan Chancellor <nathan@kernel.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org, x86@kernel.org,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [tip:objtool/urgent 9/23] vmlinux.o: warning: objtool: cdns_mrvl_xspi_setup_clock: unexpected end of section .text.cdns_mrvl_xspi_setup_clock
Date: Sun, 30 Mar 2025 12:38:09 -0700 [thread overview]
Message-ID: <20250330193809.GA62063@ax162> (raw)
In-Reply-To: <rza3hjwh5j4trizohbc4um53mej4nz7ie6adydbepncxjpoqd2@l67idl6i5mmy>
On Sat, Mar 29, 2025 at 07:44:26PM -0700, Josh Poimboeuf wrote:
> On Sat, Mar 29, 2025 at 01:06:56PM -0700, Nathan Chancellor wrote:
> > On Fri, Mar 28, 2025 at 09:46:06PM -0700, Josh Poimboeuf wrote:
> > > On Fri, Mar 28, 2025 at 04:24:49PM -0700, Nathan Chancellor wrote:
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data: unexpected end of section .text.synaptics_report_mt_data
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data+0x33e: (branch)
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data+0x254: (branch)
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data+0x1d4: (branch)
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data+0x1b8: (branch)
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data+0x156: (branch)
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data+0x13a: (branch)
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data+0xda: (branch)
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data+0xbe: (branch)
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data+0x63: (branch)
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data+0x48: (branch)
> > > > vmlinux.o: warning: objtool: synaptics_report_mt_data+0x0: <=== (sym)
> > > > ./tools/objtool/objtool --hacks=jump_label --hacks=noinstr --static-call --uaccess --noinstr --link vmlinux.o.orig -o vmlinux.o
> > >
> > > Nice! Can you share the disassembly of the function?
> >
> > Sure thing!
> >
> > > objdump -drw -j .text.synaptics_report_mt_data vmlinux.o.orig
> >
> > 0000000000000000 <synaptics_report_mt_data>:
>
> This is KCOV leaving dead code again. I thought I had silenced those
> with
>
> 6b023c784204 ("objtool: Silence more KCOV warnings")
>
> but it looks like I mixed up GCOV_KERNEL with KCOV.
>
> Can you confirm this fixes?
Can confirm, that makes both warnings disappear in this configuration.
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index b93597420daf..4d543054f723 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -275,7 +275,7 @@ objtool-args-$(CONFIG_MITIGATION_SLS) += --sls
> objtool-args-$(CONFIG_STACK_VALIDATION) += --stackval
> objtool-args-$(CONFIG_HAVE_STATIC_CALL_INLINE) += --static-call
> objtool-args-$(CONFIG_HAVE_UACCESS_VALIDATION) += --uaccess
> -objtool-args-$(CONFIG_GCOV_KERNEL) += --no-unreachable
> +objtool-args-$(or $(CONFIG_GCOV_KERNEL),$(CONFIG_KCOV)) += --no-unreachable
> objtool-args-$(CONFIG_PREFIX_SYMBOLS) += --prefix=$(CONFIG_FUNCTION_PADDING_BYTES)
> objtool-args-$(CONFIG_OBJTOOL_WERROR) += --Werror
>
prev parent reply other threads:[~2025-03-30 19:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 14:49 [tip:objtool/urgent 9/23] vmlinux.o: warning: objtool: cdns_mrvl_xspi_setup_clock: unexpected end of section .text.cdns_mrvl_xspi_setup_clock kernel test robot
2025-03-28 16:31 ` Josh Poimboeuf
2025-03-28 23:24 ` Nathan Chancellor
2025-03-29 4:46 ` Josh Poimboeuf
2025-03-29 20:06 ` Nathan Chancellor
2025-03-30 2:44 ` Josh Poimboeuf
2025-03-30 19:38 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250330193809.GA62063@ax162 \
--to=nathan@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mingo@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.