All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: bin.lan.cn@windriver.com, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.1.y] media: i2c: et8ek8: Don't strip remove function when driver is builtin
Date: Mon, 31 Mar 2025 10:48:16 -0400	[thread overview]
Message-ID: <20250331102541-0bf68e6012a148c1@stable.kernel.org> (raw)
In-Reply-To: <20250331064549.3180155-1-bin.lan.cn@windriver.com>

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: 545b215736c5c4b354e182d99c578a472ac9bfce

WARNING: Author mismatch between patch and upstream commit:
Backport author: bin.lan.cn@windriver.com
Commit author: Uwe Kleine-König<u.kleine-koenig@pengutronix.de>

Status in newer kernel trees:
6.13.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (different SHA1: c1a3803e5bb9)

Note: The patch differs from the upstream commit:
---
1:  545b215736c5c ! 1:  c13245918af57 media: i2c: et8ek8: Don't strip remove function when driver is builtin
    @@ Metadata
      ## Commit message ##
         media: i2c: et8ek8: Don't strip remove function when driver is builtin
     
    +    [ Upstream commit 545b215736c5c4b354e182d99c578a472ac9bfce ]
    +
         Using __exit for the remove function results in the remove callback
         being discarded with CONFIG_VIDEO_ET8EK8=y. When such a device gets
         unbound (e.g. using sysfs or hotplug), the driver is just removed
    @@ Commit message
         Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
         Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
         Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    +    Signed-off-by: Bin Lan <bin.lan.cn@windriver.com>
    +    Signed-off-by: He Zhe <zhe.he@windriver.com>
     
      ## drivers/media/i2c/et8ek8/et8ek8_driver.c ##
     @@ drivers/media/i2c/et8ek8/et8ek8_driver.c: static int et8ek8_probe(struct i2c_client *client)
    @@ drivers/media/i2c/et8ek8/et8ek8_driver.c: static int et8ek8_probe(struct i2c_cli
     @@ drivers/media/i2c/et8ek8/et8ek8_driver.c: static struct i2c_driver et8ek8_i2c_driver = {
      		.of_match_table	= et8ek8_of_table,
      	},
    - 	.probe		= et8ek8_probe,
    + 	.probe_new	= et8ek8_probe,
     -	.remove		= __exit_p(et8ek8_remove),
     +	.remove		= et8ek8_remove,
      	.id_table	= et8ek8_id_table,
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.1.y        |  Success    |  Success   |

      reply	other threads:[~2025-03-31 14:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31  6:45 [PATCH 6.1.y] media: i2c: et8ek8: Don't strip remove function when driver is builtin bin.lan.cn
2025-03-31 14:48 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250331102541-0bf68e6012a148c1@stable.kernel.org \
    --to=sashal@kernel.org \
    --cc=bin.lan.cn@windriver.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.