From: Jonathan Cameron <jic23@kernel.org>
To: Zhang Lixu <lixu.zhang@intel.com>
Cc: linux-iio@vger.kernel.org, lars@metafoo.de, jikos@kernel.org,
srinivas.pandruvada@linux.intel.com, peterz@infradead.org,
gregkh@linuxfoundation.org, ribalda@chromium.org,
archana.patni@linux.intel.com, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, even.xu@intel.com
Subject: Re: [PATCH 0/3] iio: hid-sensor-prox: fix SCALE and OFFSET calculation
Date: Mon, 31 Mar 2025 12:00:40 +0100 [thread overview]
Message-ID: <20250331120040.75d0577e@jic23-huawei> (raw)
In-Reply-To: <20250331055022.1149736-1-lixu.zhang@intel.com>
On Mon, 31 Mar 2025 13:50:19 +0800
Zhang Lixu <lixu.zhang@intel.com> wrote:
> This patch series addresses issues in the hid-sensor-prox driver related to
> SCALE and OFFSET calculations. The changes include restoring lost scale
> assignments, supporting multi-channel SCALE calculation, and fixing incorrect
> OFFSET calculation.
>
Hi.
Generally I prefer to see review tags (Srinivas' Acks here) given on list
but in I trust Srinivas to have done a thorough review (or to shout when he
sees this!) and the changes look correct to me, applied to the fixes-togreg-testing
branch of iio.git.
Odd point in merge cycle hence the odd temporary branch.
Jonathan
>
> Zhang Lixu (3):
> iio: hid-sensor-prox: Restore lost scale assignments
> iio: hid-sensor-prox: support multi-channel SCALE calculation
> iio: hid-sensor-prox: Fix incorrect OFFSET calculation
>
> .../hid-sensors/hid-sensor-attributes.c | 4 ++++
> drivers/iio/light/hid-sensor-prox.c | 22 ++++++++++++-------
> 2 files changed, 18 insertions(+), 8 deletions(-)
>
>
> base-commit: e21edb1638e82460f126a6e49bcdd958d452929c
next prev parent reply other threads:[~2025-03-31 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 5:50 [PATCH 0/3] iio: hid-sensor-prox: fix SCALE and OFFSET calculation Zhang Lixu
2025-03-31 5:50 ` [PATCH 1/3] iio: hid-sensor-prox: Restore lost scale assignments Zhang Lixu
2025-03-31 5:50 ` [PATCH 2/3] iio: hid-sensor-prox: support multi-channel SCALE calculation Zhang Lixu
2025-03-31 5:50 ` [PATCH 3/3] iio: hid-sensor-prox: Fix incorrect OFFSET calculation Zhang Lixu
2025-03-31 11:00 ` Jonathan Cameron [this message]
2025-03-31 14:20 ` [PATCH 0/3] iio: hid-sensor-prox: fix SCALE and " srinivas pandruvada
2025-04-01 2:12 ` Zhang, Lixu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331120040.75d0577e@jic23-huawei \
--to=jic23@kernel.org \
--cc=archana.patni@linux.intel.com \
--cc=even.xu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=peterz@infradead.org \
--cc=ribalda@chromium.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.