From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf@fomichev.me>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, Cosmin Ratiu <cratiu@nvidia.com>
Subject: Re: [PATCH net v4 01/11] net: switch to netif_disable_lro in inetdev_init
Date: Mon, 31 Mar 2025 13:43:35 -0700 [thread overview]
Message-ID: <20250331134335.009691e4@kernel.org> (raw)
In-Reply-To: <20250331150603.1906635-2-sdf@fomichev.me>
On Mon, 31 Mar 2025 08:05:53 -0700 Stanislav Fomichev wrote:
> +EXPORT_IPV6_MOD(netif_disable_lro);
> +++ b/net/ipv4/devinet.c
> if (IPV4_DEVCONF(in_dev->cnf, FORWARDING))
> - dev_disable_lro(dev);
> + netif_disable_lro(dev);
> /* Reference in_dev->dev */
> netdev_hold(dev, &in_dev->dev_tracker, GFP_KERNEL);
> /* Account for reference dev->ip_ptr (below) */
I still don't see a way for devinet.c to be built into a module.
The export and moving the defines needs to go to patch 3.
next prev parent reply other threads:[~2025-03-31 20:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 15:05 [PATCH net v4 00/11] net: hold instance lock during NETDEV_UP/REGISTER Stanislav Fomichev
2025-03-31 15:05 ` [PATCH net v4 01/11] net: switch to netif_disable_lro in inetdev_init Stanislav Fomichev
2025-03-31 20:43 ` Jakub Kicinski [this message]
2025-03-31 21:06 ` Stanislav Fomichev
2025-03-31 15:05 ` [PATCH net v4 02/11] net: hold instance lock during NETDEV_REGISTER/UP Stanislav Fomichev
2025-03-31 20:48 ` Jakub Kicinski
2025-03-31 21:13 ` Stanislav Fomichev
2025-03-31 21:27 ` Jakub Kicinski
2025-03-31 15:05 ` [PATCH net v4 03/11] net: use netif_disable_lro in ipv6_add_dev Stanislav Fomichev
2025-03-31 15:05 ` [PATCH net v4 04/11] net: rename rtnl_net_debug to lock_debug Stanislav Fomichev
2025-03-31 20:48 ` Jakub Kicinski
2025-03-31 15:05 ` [PATCH net v4 05/11] netdevsim: add dummy device notifiers Stanislav Fomichev
2025-03-31 20:54 ` Jakub Kicinski
2025-03-31 21:20 ` Stanislav Fomichev
2025-03-31 15:05 ` [PATCH net v4 06/11] net: dummy: request ops lock Stanislav Fomichev
2025-03-31 15:05 ` [PATCH net v4 07/11] docs: net: document netdev notifier expectations Stanislav Fomichev
2025-03-31 20:58 ` Jakub Kicinski
2025-03-31 21:49 ` Stanislav Fomichev
2025-03-31 15:06 ` [PATCH net v4 08/11] selftests: net: use netdevsim in netns test Stanislav Fomichev
2025-03-31 15:06 ` [PATCH net v4 09/11] net: designate XSK pool pointers in queues as "ops protected" Stanislav Fomichev
2025-03-31 15:06 ` [PATCH net v4 10/11] netdev: add "ops compat locking" helpers Stanislav Fomichev
2025-03-31 15:06 ` [PATCH net v4 11/11] netdev: don't hold rtnl_lock over nl queue info get when possible Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250331134335.009691e4@kernel.org \
--to=kuba@kernel.org \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.