From: Simon Horman <horms@kernel.org>
To: Pedro Tammela <pctammela@mojatatu.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: tc-testing: fix nat regex matching
Date: Tue, 1 Apr 2025 10:53:49 +0100 [thread overview]
Message-ID: <20250401095349.GC214849@horms.kernel.org> (raw)
In-Reply-To: <20250331195618.535992-1-pctammela@mojatatu.com>
On Mon, Mar 31, 2025 at 04:56:18PM -0300, Pedro Tammela wrote:
> In iproute 6.14, the nat ip mask logic was fixed to remove a undefined
> behaviour. So now instead of reporting '0.0.0.0/32' on x86 and potentially
> '0.0.0.0/0' in other platforms, it reports '0.0.0.0/0' in all platforms.
>
Hi Pedro,
As a fix for 'net' usually a Fixes tag would go here.
But perhaps that isn't appropriate in this case for some reason?
> Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
I am assuming that you are referring to this fix:
- [PATCH iproute2-next] tc: nat: Fix mask calculation
https://lore.kernel.org/netdev/20250306112520.188728-1-torben.nielsen@prevas.dk/
If so, it might be nice to include a reference to it in the commit message.
And also, if so, this change looks good to me:
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-04-01 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 19:56 [PATCH net] selftests: tc-testing: fix nat regex matching Pedro Tammela
2025-04-01 9:53 ` Simon Horman [this message]
2025-04-01 14:29 ` Pedro Tammela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250401095349.GC214849@horms.kernel.org \
--to=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pctammela@mojatatu.com \
--cc=shuah@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.