From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: Linux Test Project <ltp@lists.linux.it>, rbm@suse.com
Subject: Re: [LTP] [PATCH v5 1/3] syscalls/modify_ldt: Add lapi/ldt.h
Date: Tue, 1 Apr 2025 12:21:32 +0200 [thread overview]
Message-ID: <20250401102132.GA345164@pevik> (raw)
In-Reply-To: <be455754-b62e-47f6-97bf-086f90078fa1@suse.com>
Hi Andrea,
> Hi Petr,
> On 4/1/25 10:48, Petr Vorel wrote:
> > nit: IMHO modify_ldt() is not used anywhere outside lapi file, right?
> > I would also consider instead of creating modify_ldt() just put raw syscall:
> > rval = tst_syscall(__NR_modify_ldt, func, &ptr, bytecount);
> Just yesterday I got a review from @Cyril asking me to add syscalls function
> definition which are missing inside the lapi/.h header. The reason is that
> we want to fallback libc and eventually check for HAVE_FUNCT_* via
> autotools.
> In general I agree with this approach.
OK, no problem, thanks for info.
Kind regards,
Petr
> Kind regards,
> Andrea Cervesato
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-04-01 10:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 17:43 [LTP] [PATCH v5 0/3] syscalls/modify_ldt: Refactor into new API Ricardo B. Marliere via ltp
2025-03-31 17:43 ` [LTP] [PATCH v5 1/3] syscalls/modify_ldt: Add lapi/ldt.h Ricardo B. Marliere via ltp
2025-04-01 8:48 ` Petr Vorel
2025-04-01 8:56 ` Andrea Cervesato via ltp
2025-04-01 10:21 ` Petr Vorel [this message]
2025-04-01 13:55 ` Ricardo B. Marli��re via ltp
2025-04-01 10:29 ` Petr Vorel
2025-04-01 10:45 ` Ricardo B. Marli��re via ltp
2025-03-31 17:43 ` [LTP] [PATCH v5 2/3] syscalls/modify_ldt02: Refactor into new API Ricardo B. Marliere via ltp
2025-03-31 17:43 ` [LTP] [PATCH v5 3/3] syscalls/modify_ldt01: " Ricardo B. Marliere via ltp
2025-03-31 17:55 ` Ricardo B. Marli��re via ltp
2025-03-31 17:58 ` Ricardo B. Marli��re via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250401102132.GA345164@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
--cc=rbm@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.