All of lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: <intel-gfx@lists.freedesktop.org>, <intel-xe@lists.freedesktop.org>
Cc: <dri-devel@lists.freedesktop.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Lyude Paul <lyude@redhat.com>
Subject: [PATCH 2/2] drm/dp_mst: Use drm_dp_dpcd_write_data() to write GUID for non-root MST branch devices
Date: Tue, 1 Apr 2025 13:38:46 +0300	[thread overview]
Message-ID: <20250401103846.686408-2-imre.deak@intel.com> (raw)
In-Reply-To: <20250401103846.686408-1-imre.deak@intel.com>

drm_dp_dpcd_write_data() can be used to write the GUID for a non-root
MST branch device, similarly to writing the GUID to a root MST branch
device, do so.

Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Lyude Paul <lyude@redhat.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/display/drm_dp_mst_topology.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
index 619f461e02f76..a89f38fd3218b 100644
--- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
@@ -2192,20 +2192,17 @@ static int drm_dp_check_mstb_guid(struct drm_dp_mst_branch *mstb, guid_t *guid)
 	guid_copy(&mstb->guid, guid);
 
 	if (!drm_dp_validate_guid(mstb->mgr, &mstb->guid)) {
+		struct drm_dp_aux *aux;
 		u8 buf[UUID_SIZE];
 
 		export_guid(buf, &mstb->guid);
 
-		if (mstb->port_parent) {
-			ret = drm_dp_send_dpcd_write(mstb->mgr,
-						     mstb->port_parent,
-						     DP_GUID, sizeof(buf), buf);
-			if (ret >= 0)
-				ret = ret == sizeof(buf) ? 0 : -EPROTO;
-		} else {
-			ret = drm_dp_dpcd_write_data(mstb->mgr->aux,
-						     DP_GUID, buf, sizeof(buf));
-		}
+		if (mstb->port_parent)
+			aux = &mstb->port_parent->aux;
+		else
+			aux = mstb->mgr->aux;
+
+		ret = drm_dp_dpcd_write_data(aux, DP_GUID, buf, sizeof(buf));
 	}
 
 	return ret;
-- 
2.44.2


  reply	other threads:[~2025-04-01 10:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 10:38 [PATCH 1/2] drm/dp_mst: Fix GUID DPCD write to non-root MST branch devices Imre Deak
2025-04-01 10:38 ` Imre Deak [this message]
2025-04-01 10:43 ` ✓ CI.Patch_applied: success for series starting with [1/2] " Patchwork
2025-04-01 10:43 ` ✓ CI.checkpatch: " Patchwork
2025-04-01 10:44 ` ✓ CI.KUnit: " Patchwork
2025-04-01 11:01 ` ✓ CI.Build: " Patchwork
2025-04-01 11:03 ` ✓ CI.Hooks: " Patchwork
2025-04-01 11:05 ` ✓ CI.checksparse: " Patchwork
2025-04-01 11:40 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-01 11:46 ` ✓ i915.CI.BAT: " Patchwork
2025-04-01 13:54 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-01 14:43 ` [PATCH 1/2] " Jani Nikula
2025-04-01 15:47 ` ✗ i915.CI.Full: failure for series starting with [1/2] " Patchwork
2025-04-03 18:49   ` Imre Deak
2025-04-02 21:13 ` [PATCH 1/2] " Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250401103846.686408-2-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lyude@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.