From: Anshuman Gupta <anshuman.gupta@intel.com>
To: intel-xe@lists.freedesktop.org, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org
Cc: rafael@kernel.org, lenb@kernel.org, bhelgaas@google.com,
ilpo.jarvinen@linux.intel.com, lucas.demarchi@intel.com,
rodrigo.vivi@intel.com, badal.nilawar@intel.com,
anshuman.gupta@intel.com, varun.gupta@intel.com,
ville.syrjala@linux.intel.com, uma.shankar@intel.com
Subject: [PATCH 02/12] PCI/ACPI: Add PERST# Assertion Delay _DSM method
Date: Tue, 1 Apr 2025 21:02:15 +0530 [thread overview]
Message-ID: <20250401153225.96379-3-anshuman.gupta@intel.com> (raw)
In-Reply-To: <20250401153225.96379-1-anshuman.gupta@intel.com>
Implement _DSM Method 11 as per PCI firmware specs
section 4.6.11 Rev 3.3.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
drivers/pci/pci-acpi.c | 53 ++++++++++++++++++++++++++++++++++++++++
include/linux/pci-acpi.h | 7 ++++++
2 files changed, 60 insertions(+)
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index ebd49e43457e..04149f037664 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -1499,6 +1499,59 @@ int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
}
EXPORT_SYMBOL(pci_acpi_request_d3cold_aux_power);
+/**
+ * pci_acpi_add_perst_assertion_delay - Request PERST# delay via ACPI DSM
+ * @dev: PCI device instance
+ * @delay_us: Requested delay_us
+ *
+ * This function sends a request to the host BIOS via ACPI _DSM to grant the
+ * required PERST# delay for the specified PCI device. It evaluates the _DSM
+ * to request the PERST# delay and handles the response accordingly.
+ *
+ * Return: returns 0 on success and errno on failure.
+ */
+int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
+{
+ union acpi_object in_obj = {
+ .integer.type = ACPI_TYPE_INTEGER,
+ .integer.value = delay_us,
+ };
+
+ union acpi_object *out_obj;
+ acpi_handle handle;
+ int result, ret = -EINVAL;
+
+ if (!dev || !ACPI_HANDLE(&dev->dev))
+ return -EINVAL;
+
+ handle = ACPI_HANDLE(&dev->dev);
+
+ out_obj = acpi_evaluate_dsm_typed(handle, &pci_acpi_dsm_guid, 4,
+ DSM_PCI_PERST_ASSERTION_DELAY,
+ &in_obj, ACPI_TYPE_INTEGER);
+ if (!out_obj)
+ return -EINVAL;
+
+ result = out_obj->integer.value;
+
+ if (result == delay_us) {
+ dev_info(&dev->dev, "PERST# Assertion Delay set to"
+ "%u microseconds\n", delay_us);
+ ret = 0;
+ } else if (result == 0) {
+ dev_warn(&dev->dev, "PERST# Assertion Delay request failed,"
+ "no previous valid request\n");
+ } else {
+ dev_warn(&dev->dev,
+ "PERST# Assertion Delay request failed"
+ "Previous valid delay: %u microseconds\n", result);
+ }
+
+ ACPI_FREE(out_obj);
+ return ret;
+}
+EXPORT_SYMBOL(pci_acpi_add_perst_assertion_delay);
+
static void pci_acpi_set_external_facing(struct pci_dev *dev)
{
u8 val;
diff --git a/include/linux/pci-acpi.h b/include/linux/pci-acpi.h
index dbc4b0ed433c..4b7373f91a9a 100644
--- a/include/linux/pci-acpi.h
+++ b/include/linux/pci-acpi.h
@@ -122,6 +122,7 @@ extern const guid_t pci_acpi_dsm_guid;
#define DSM_PCI_POWER_ON_RESET_DELAY 0x08
#define DSM_PCI_DEVICE_READINESS_DURATIONS 0x09
#define DSM_PCI_D3COLD_AUX_POWER_LIMIT 0x0A
+#define DSM_PCI_PERST_ASSERTION_DELAY 0x0B
#ifdef CONFIG_PCIE_EDR
void pci_acpi_add_edr_notifier(struct pci_dev *pdev);
@@ -134,6 +135,7 @@ static inline void pci_acpi_remove_edr_notifier(struct pci_dev *pdev) { }
int pci_acpi_set_companion_lookup_hook(struct acpi_device *(*func)(struct pci_dev *));
void pci_acpi_clear_companion_lookup_hook(void);
int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power);
+int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us);
#else /* CONFIG_ACPI */
static inline void acpi_pci_add_bus(struct pci_bus *bus) { }
@@ -142,6 +144,11 @@ int pci_acpi_request_d3cold_aux_power(struct pci_dev *dev, u32 requested_power)
{
return -EOPNOTSUPP;
}
+
+int pci_acpi_add_perst_assertion_delay(struct pci_dev *dev, u32 delay_us)
+{
+ return -EOPNOTSUPP;
+}
#endif /* CONFIG_ACPI */
#endif /* _PCI_ACPI_H_ */
--
2.43.0
next prev parent reply other threads:[~2025-04-01 15:36 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 15:32 [PATCH 00/12] VRAM Self Refresh Anshuman Gupta
2025-04-01 15:32 ` [PATCH 01/12] PCI/ACPI: Add D3cold Aux Power Limit_DSM method Anshuman Gupta
2025-04-01 18:25 ` Bjorn Helgaas
2025-04-02 10:59 ` Rafael J. Wysocki
2025-04-03 5:25 ` Gupta, Anshuman
2025-04-01 15:32 ` Anshuman Gupta [this message]
2025-04-01 18:30 ` [PATCH 02/12] PCI/ACPI: Add PERST# Assertion Delay _DSM method Bjorn Helgaas
2025-04-03 5:59 ` Gupta, Anshuman
2025-04-02 11:06 ` Rafael J. Wysocki
2025-04-02 14:21 ` Bjorn Helgaas
2025-04-02 14:52 ` Rafael J. Wysocki
2025-04-02 15:50 ` Bjorn Helgaas
2025-04-02 17:51 ` Rafael J. Wysocki
2025-04-02 18:48 ` Bjorn Helgaas
2025-04-02 19:36 ` Rafael J. Wysocki
2025-04-08 20:48 ` Bjorn Helgaas
2025-04-09 12:30 ` Rafael J. Wysocki
2025-04-09 14:47 ` Bjorn Helgaas
2025-04-09 16:28 ` Rafael J. Wysocki
2025-04-01 15:32 ` [PATCH 03/12] PCI/ACPI: Add aux power grant notifier Anshuman Gupta
2025-04-01 20:13 ` Bjorn Helgaas
2025-04-02 11:23 ` Rafael J. Wysocki
2025-04-03 11:30 ` Gupta, Anshuman
2025-04-03 13:34 ` Rafael J. Wysocki
2025-04-03 16:08 ` Gupta, Anshuman
2025-04-03 18:15 ` Rafael J. Wysocki
2025-04-04 12:53 ` Gupta, Anshuman
2025-04-08 13:01 ` Rafael J. Wysocki
2025-05-29 11:31 ` Nilawar, Badal
2025-04-03 7:56 ` Gupta, Anshuman
2025-04-03 13:48 ` Rafael J. Wysocki
2025-04-01 15:32 ` [PATCH 04/12] drm/xe/vrsr: Introduce flag has_vrsr Anshuman Gupta
2025-04-01 15:32 ` [PATCH 05/12] drm/xe/vrsr: Detect VRSR Capability Anshuman Gupta
2025-04-01 15:32 ` [PATCH 06/12] drm/xe/vrsr: Initialize VRSR feature Anshuman Gupta
2025-04-01 19:56 ` Bjorn Helgaas
2025-04-03 6:09 ` Gupta, Anshuman
2025-04-01 15:32 ` [PATCH 07/12] drm/xe/vrsr: Enable VRSR on default VGA boot device Anshuman Gupta
2025-04-01 15:32 ` [PATCH 08/12] drm/xe: Add PCIe ACPI Aux Power notifier Anshuman Gupta
2025-04-01 15:32 ` [PATCH 09/12] drm/xe/vrsr: Refactor d3cold.allowed to a enum Anshuman Gupta
2025-04-01 15:32 ` [PATCH 10/12] drm/xe/pm: D3Cold target state Anshuman Gupta
2025-04-02 10:28 ` [10/12] " Poosa, Karthik
2025-04-01 15:32 ` [PATCH 11/12] drm/xe/vrsr: Enable VRSR Anshuman Gupta
2025-04-01 15:32 ` [PATCH 12/12] drm/xe/vrsr: Introduce a debugfs node named vrsr_capable Anshuman Gupta
2025-04-01 15:42 ` ✓ CI.Patch_applied: success for VRAM Self Refresh (rev2) Patchwork
2025-04-01 15:42 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-01 15:42 ` ✗ CI.KUnit: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250401153225.96379-3-anshuman.gupta@intel.com \
--to=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=rafael@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=uma.shankar@intel.com \
--cc=varun.gupta@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.