Re: [PATCH v5 0/4] virtio_net: Add the check for vdpa's mac address

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Mar 26, 2025 at 09:19:29PM +0800, Cindy Lu wrote:
> When using a VDPA device, it is important to ensure that the MAC address
> is correctly set. In this patch series, we add a new parameter to
> enable this check.
> Only three MAC setup configurations are acceptable; any other will
> fail to boot.
> 
> The usage is:
> ....
> -netdev type=vhost-vdpa,vhostdev=/dev/vhost-vdpa-0,id=vhost-vdpa0,check-mac=true\
> -device virtio-net-pci,netdev=vhost-vdpa0\
> ....
> 
> tested by ConnectX-6 Dx/vdpa_sim device
> 
> change in v3
> 1. add a new parameter to enable the check and keep the old behavior
> 2. adjust the comment and make it more clear
> 
> change in v4
> 1. change the new parameter's name to check-mac
> 2. change the comment and make it more clear
> 
> change in v5
> 1.These patches haven't been merged for a while, so I rebased
>   them with the latest code and resubmitted
> 
> Cindy Lu (4):
>   vhost_vdpa : Add a new parameter to enable check mac address
>   virtio_net: Add the check for vdpa's mac address
>   virtio_net: Add second acceptable configuration for MAC setup
>   virtio_net: Add third acceptable configuration for MAC setup.
> 
>  hw/net/virtio-net.c | 67 ++++++++++++++++++++++++++++++++++++++++++++-
>  include/net/net.h   |  1 +
>  net/vhost-vdpa.c    |  4 +++
>  qapi/net.json       |  5 ++++
>  4 files changed, 76 insertions(+), 1 deletion(-)


some minor nits.

> -- 
> 2.45.0