Re: [PATCH v2 1/3] staging: rtl8723bs: Modify struct rx_pkt_attrib attribute bdecrypted

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Apr 02, 2025 at 08:16:42PM +0300, Erick Karanja wrote:
> Standardize boolean representation by ensuring consistency,
> replace instances of 1/0 with true/false where boolean logic is implied,
> as some definitions already use true/false.
> This improves code clarity and aligns with the kernel’s bool type usage.
> 
> Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index a389ba5ecc6f..fd04dbacb50f 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1358,7 +1358,7 @@ static signed int validate_80211w_mgmt(struct adapter *adapter, union recv_frame
>  			u8 *mgmt_DATA;
>  			u32 data_len = 0;
>  
> -			pattrib->bdecrypted = 0;
> +			pattrib->bdecrypted = false;

but bdecrypted is a u8, not a boolean type.  So setting it to "false"
does not seem correct here, right?

Also, the name of the variable should really be changed.

But, step back, are you _SURE_ you can change this structure at all?
At a quick glance it kind of looks like it comes directly from the
hardware, or am I mis-reading the driver code?

Have you tested this series on an actual device?

thanks,

greg k-h