drivers/gpu/drm/vc4/vc4_gem.c:604 vc4_lock_bo_reservations() error: uninitialized symbol 'ret'.

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Maíra Canal" <mcanal@igalia.com>
CC: Melissa Wen <mwen@igalia.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   acc4d5ff0b61eb1715c498b6536c38c1feb7f3c1
commit: 04630796c437a9285643097825cbd3cd06603f47 drm/vc4: Use DRM Execution Contexts
date:   2 months ago
:::::: branch date: 4 hours ago
:::::: commit date: 2 months ago
config: arm64-randconfig-r073-20250402 (https://download.01.org/0day-ci/archive/20250402/202504021500.3AM1hKKS-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202504021500.3AM1hKKS-lkp@intel.com/

smatch warnings:
drivers/gpu/drm/vc4/vc4_gem.c:604 vc4_lock_bo_reservations() error: uninitialized symbol 'ret'.

vim +/ret +604 drivers/gpu/drm/vc4/vc4_gem.c

cdec4d3613230f Eric Anholt 2017-04-12  581  
cdec4d3613230f Eric Anholt 2017-04-12  582  /* Takes the reservation lock on all the BOs being referenced, so that
cdec4d3613230f Eric Anholt 2017-04-12  583   * at queue submit time we can update the reservations.
cdec4d3613230f Eric Anholt 2017-04-12  584   *
cdec4d3613230f Eric Anholt 2017-04-12  585   * We don't lock the RCL the tile alloc/state BOs, or overflow memory
cdec4d3613230f Eric Anholt 2017-04-12  586   * (all of which are on exec->unref_list).  They're entirely private
cdec4d3613230f Eric Anholt 2017-04-12  587   * to vc4, so we don't attach dma-buf fences to them.
cdec4d3613230f Eric Anholt 2017-04-12  588   */
cdec4d3613230f Eric Anholt 2017-04-12  589  static int
04630796c437a9 Maíra Canal 2024-12-20  590  vc4_lock_bo_reservations(struct vc4_exec_info *exec,
04630796c437a9 Maíra Canal 2024-12-20  591  			 struct drm_exec *exec_ctx)
cdec4d3613230f Eric Anholt 2017-04-12  592  {
04630796c437a9 Maíra Canal 2024-12-20  593  	int ret;
cdec4d3613230f Eric Anholt 2017-04-12  594  
cdec4d3613230f Eric Anholt 2017-04-12  595  	/* Reserve space for our shared (read-only) fence references,
cdec4d3613230f Eric Anholt 2017-04-12  596  	 * before we commit the CL to the hardware.
cdec4d3613230f Eric Anholt 2017-04-12  597  	 */
04630796c437a9 Maíra Canal 2024-12-20  598  	drm_exec_init(exec_ctx, DRM_EXEC_INTERRUPTIBLE_WAIT, exec->bo_count);
04630796c437a9 Maíra Canal 2024-12-20  599  	drm_exec_until_all_locked(exec_ctx) {
04630796c437a9 Maíra Canal 2024-12-20  600  		ret = drm_exec_prepare_array(exec_ctx, exec->bo,
04630796c437a9 Maíra Canal 2024-12-20  601  					     exec->bo_count, 1);
04630796c437a9 Maíra Canal 2024-12-20  602  	}
cdec4d3613230f Eric Anholt 2017-04-12  603  
cdec4d3613230f Eric Anholt 2017-04-12 @604  	if (ret) {
04630796c437a9 Maíra Canal 2024-12-20  605  		drm_exec_fini(exec_ctx);
cdec4d3613230f Eric Anholt 2017-04-12  606  		return ret;
7edabee06a5622 Eric Anholt 2016-09-27  607  	}
d5b1a78a772f1e Eric Anholt 2015-11-30  608  
cdec4d3613230f Eric Anholt 2017-04-12  609  	return 0;
cdec4d3613230f Eric Anholt 2017-04-12  610  }
cdec4d3613230f Eric Anholt 2017-04-12  611  

:::::: The code at line 604 was first introduced by commit
:::::: cdec4d3613230fc15723fae206cb17825b914cee drm/vc4: Expose dma-buf fences for V3D rendering.

:::::: TO: Eric Anholt <eric@anholt.net>
:::::: CC: Eric Anholt <eric@anholt.net>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki