All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>,
	patches@opensource.cirrus.com, kunit-dev@googlegroups.com,
	linux-kselftest@vger.kernel.org
Subject: Re: Exclude cirrus FW tests from KUNIT_ALL_TESTS
Date: Wed, 2 Apr 2025 15:56:44 -0700	[thread overview]
Message-ID: <20250402155644.67b2cb3c@kernel.org> (raw)
In-Reply-To: <a91811dd-6f86-4af1-8d91-02b990ef2fe3@sirena.org.uk>

On Wed, 2 Apr 2025 18:55:29 +0100 Mark Brown wrote:
> On Wed, Apr 02, 2025 at 10:36:55AM -0700, Jakub Kicinski wrote:
> 
> > The Cirrus tests keep failing for me when run on x86  
> >  ./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64  
> > https://netdev-3.bots.linux.dev/kunit/results/60103/stdout  
> 
> You've not said what tree you're testing there but everything is fine in
> -next AFAICT, and there is one fix for cs_dsp on it's way to Linus at
> the minute specifically for KUnit.
> 
> > It seems like new cases continue to appear and we have to keep adding
> > them to the local ignored list. Is it possible to get these fixed or
> > can we exclude the cirrus tests from KUNIT_ALL_TESTS?  
> 
> This is the first report I've seen from you...

More of a test balloon that a real report as you alluded to.
I was wondering if it's just me, and from your response it seems 
to be just me.

I did more digging and with newer compilers I don't see the issue
either. So I did:

  ./tools/testing/kunit/kunit.py run --alltests --json --arch=x86_64 \
	 --kconfig_add CONFIG_INIT_STACK_ALL_ZERO=n 

And the problem reproduces on recent compilers, too. Which leads me
to thinking that the tests are broken but stack init covers it up.. ?
Strangely tho

	make W=1 LLVM=1 ...

doesn't report any uninitialized variable warnings.

  reply	other threads:[~2025-04-02 22:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02 17:36 Exclude cirrus FW tests from KUNIT_ALL_TESTS Jakub Kicinski
2025-04-02 17:55 ` Mark Brown
2025-04-02 22:56   ` Jakub Kicinski [this message]
2025-04-03 11:49     ` Mark Brown
2025-04-03  6:19   ` David Gow
2025-04-03 13:26     ` Mark Brown
2025-04-03 16:57       ` Richard Fitzgerald
2025-04-03 17:47         ` Mark Brown
2025-04-04  6:53           ` David Gow
2025-04-04 11:10             ` Richard Fitzgerald
2025-04-04 14:03               ` Mark Brown
2025-04-03 16:52 ` Richard Fitzgerald
2025-04-07  9:41 ` Richard Fitzgerald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250402155644.67b2cb3c@kernel.org \
    --to=kuba@kernel.org \
    --cc=broonie@kernel.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=rf@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.