From: Halil Pasic <pasic@linux.ibm.com>
To: Amit Shah <amit@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
Cc: stable@vger.kernel.org,
"Maximilian Immanuel Brandtner" <maxbr@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [PATCH 1/1] virtio_console: fix missing byte order handling for cols and rows
Date: Wed, 2 Apr 2025 17:26:59 +0200 [thread overview]
Message-ID: <20250402172659.59df72d2.pasic@linux.ibm.com> (raw)
In-Reply-To: <20250322002954.3129282-1-pasic@linux.ibm.com>
On Sat, 22 Mar 2025 01:29:54 +0100
Halil Pasic <pasic@linux.ibm.com> wrote:
> As per virtio spec the fields cols and rows are specified as little
> endian.
[..]
@Amit: Any feedback?
>
> Fixes: 8345adbf96fc1 ("virtio: console: Accept console size along with resize control message")
> Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
> Cc: stable@vger.kernel.org # v2.6.35+
> ---
>
> @Michael: I think it would be nice to add a clarification on the byte
> order to be used for cols and rows when the legacy interface is used to
> the spec, regardless of what we decide the right byte order is. If
> it is native endian that shall be stated much like it is stated for
> virtio_console_control. If it is little endian, I would like to add
> a sentence that states that unlike for the fields of virtio_console_control
> the byte order of the fields of struct virtio_console_resize is little
> endian also when the legacy interface is used.
@MST: any opinion on that?
[..]
next prev parent reply other threads:[~2025-04-02 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 0:29 [PATCH 1/1] virtio_console: fix missing byte order handling for cols and rows Halil Pasic
2025-03-24 17:56 ` Maximilian Immanuel Brandtner
2025-04-02 15:26 ` Halil Pasic [this message]
2025-04-02 15:40 ` Michael S. Tsirkin
2025-04-16 13:49 ` Amit Shah
2025-04-22 10:39 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402172659.59df72d2.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxbr@linux.ibm.com \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.