From: Oliver Upton <oliver.upton@linux.dev>
To: kvmarm@lists.linux.dev
Cc: Marc Zyngier <maz@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Jiaqi Yan <jiaqiyan@google.com>,
Oliver Upton <oliver.upton@linux.dev>
Subject: [PATCH v2 0/3] KVM: arm64: Fixes for resolving the fault IPA
Date: Wed, 2 Apr 2025 13:17:22 -0700 [thread overview]
Message-ID: <20250402201725.2963645-1-oliver.upton@linux.dev> (raw)
KVM's heuristics for determining the fault IPA are a bit shaky and don't
necessarily align with the letter of the architecture. On top of that,
HPFAR_EL2 is UNKNOWN if an SEA occurred during a table walk. Re-walking
the page tables will replay the SEA at EL2, becoming a panic in the hyp.
v1: https://lore.kernel.org/kvmarm/20250401224234.2906739-1-oliver.upton@linux.dev/
v1 -> v2 (addressed Marc's feedback):
- Drop section reference in favor of the rule for HPFAR_EL2 validity
- Fold test for Address size fault into helper, reuse existing
definitions
- Get rid of 'magic' shift for transforming FIPA field to an actual IPA
- Add BUG_ON() to handle_host_mem_abort() if we fail to resolve the
fault IPA.
Oliver Upton (3):
KVM: arm64: Only read HPFAR_EL2 when value is architecturally valid
arm64: Convert HPFAR_EL2 to sysreg table
KVM: arm64: Don't translate FAR if invalid/unsafe
arch/arm64/include/asm/esr.h | 44 +++++++++++++++-
arch/arm64/include/asm/kvm_emulate.h | 7 ++-
arch/arm64/include/asm/kvm_ras.h | 2 +-
arch/arm64/kvm/hyp/include/hyp/fault.h | 70 ++++++++++++++++++--------
arch/arm64/kvm/hyp/nvhe/mem_protect.c | 9 +++-
arch/arm64/kvm/mmu.c | 31 +++++++-----
arch/arm64/tools/sysreg | 7 +++
7 files changed, 131 insertions(+), 39 deletions(-)
base-commit: 369c0122682c4468a69f2454614eded71c5348f3
--
2.39.5
next reply other threads:[~2025-04-02 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 20:17 Oliver Upton [this message]
2025-04-02 20:17 ` [PATCH v2 1/3] KVM: arm64: Only read HPFAR_EL2 when value is architecturally valid Oliver Upton
2025-04-02 21:48 ` Marc Zyngier
2025-04-02 21:52 ` Oliver Upton
2025-04-03 7:04 ` Marc Zyngier
2025-04-02 20:17 ` [PATCH v2 2/3] arm64: Convert HPFAR_EL2 to sysreg table Oliver Upton
2025-04-02 20:17 ` [PATCH v2 3/3] KVM: arm64: Don't translate FAR if invalid/unsafe Oliver Upton
2025-04-02 21:53 ` [PATCH v2 0/3] KVM: arm64: Fixes for resolving the fault IPA Marc Zyngier
2025-04-03 15:45 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402201725.2963645-1-oliver.upton@linux.dev \
--to=oliver.upton@linux.dev \
--cc=jiaqiyan@google.com \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.