From: Christoph Hellwig <hch@lst.de>
To: Yaxiong Tian <iambestgod@qq.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
chaitanyak@nvidia.com, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org,
Yaxiong Tian <tianyaxiong@kylinos.cn>
Subject: Re: [PATCH v3 0/3] nvme: Add sysfs interface for APST configuration management
Date: Thu, 3 Apr 2025 06:25:04 +0200 [thread overview]
Message-ID: <20250403042504.GB22360@lst.de> (raw)
In-Reply-To: <tencent_4612952C8C5109058CD8E688D81276A2FD0A@qq.com>
On Tue, Apr 01, 2025 at 05:22:06PM +0800, Yaxiong Tian wrote:
> From: Yaxiong Tian <tianyaxiong@kylinos.cn>
>
> This series enhances NVMe APST (Autonomous Power State Transition) support by:
> 1. Adding warnings for PST table allocation failures
That looks fine.
> 2. Exposing APST tables via sysfs for runtime inspection
> 3. Providing per-controller sysfs interface for APST configuration
Who is going to use this and how? We'll need proper tools for that,
and in general I'd prefer to have a common set of policies for APST
configurations and not random people coming up with lots of random
policies.
next prev parent reply other threads:[~2025-04-03 4:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 9:22 [PATCH v3 0/3] nvme: Add sysfs interface for APST configuration management Yaxiong Tian
2025-04-01 9:26 ` [PATCH v3 1/3] nvme: Add warning for PST table memory allocation failure in nvme_configure_apst Yaxiong Tian
2025-04-03 4:25 ` Christoph Hellwig
2025-04-03 7:08 ` Yaxiong Tian
2025-04-01 9:27 ` [PATCH v3 2/3] nvme: add sysfs interface for APST table updates Yaxiong Tian
2025-04-01 9:27 ` [PATCH v3 3/3] nvme: add per-controller sysfs interface for APST configuration Yaxiong Tian
2025-04-01 22:33 ` [PATCH v3 0/3] nvme: Add sysfs interface for APST configuration management Chaitanya Kulkarni
2025-04-03 4:25 ` Christoph Hellwig [this message]
2025-04-03 7:05 ` Yaxiong Tian
2025-04-04 8:29 ` Christoph Hellwig
2025-04-06 9:14 ` Alexey Bogoslavsky
2025-04-07 1:25 ` Yaxiong Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403042504.GB22360@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=iambestgod@qq.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tianyaxiong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.