From: Christoph Hellwig <hch@lst.de>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, mikhail.v.gavrilov@gmail.com,
hch@lst.de, linux-nvme@lists.infradead.org,
mlombard@bsdbackstore.eu
Subject: Re: [PATCH 1/1] nvme-pci: do not call nvme_write_sq_db() if the commands list is empty
Date: Thu, 3 Apr 2025 06:37:10 +0200 [thread overview]
Message-ID: <20250403043710.GA22720@lst.de> (raw)
In-Reply-To: <20250331162859.1407725-2-mlombard@redhat.com>
On Mon, Mar 31, 2025 at 06:28:59PM +0200, Maurizio Lombardi wrote:
> nvme_submit_cmds() should check the rqlist
> before calling nvme_write_sq_db();
> if the list is empty, it must return immediately.
It would be useful for future readers to state why it is important.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2025-04-03 4:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 16:28 [PATCH 0/1] Fix a regression in 6.13 kernel Maurizio Lombardi
2025-03-31 16:28 ` [PATCH 1/1] nvme-pci: do not call nvme_write_sq_db() if the commands list is empty Maurizio Lombardi
2025-03-31 16:45 ` Keith Busch
2025-04-03 4:37 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403043710.GA22720@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mikhail.v.gavrilov@gmail.com \
--cc=mlombard@bsdbackstore.eu \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.