All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
	linux-nvme@lists.infradead.org, Hannes Reinecke <hare@kernel.org>
Subject: [PATCHv3 0/3] nvme-tcp: fixup I/O stall on congested sockets
Date: Thu,  3 Apr 2025 08:55:19 +0200	[thread overview]
Message-ID: <20250403065522.90807-1-hare@kernel.org> (raw)

Hi all,

I have been chasing keep-alive timeouts with TLS enabled in the last few
days (weeks, even :-( ). On larger setups (eg with 32 queues) the connection
never got established properly as I've been hitting keep-alive timeouts before
the last queue got connected.
Turns out that occasionally we simply do not send the keep-alive request; it's
been added to the request list but the io_work workqueue function is never
restarted as it bails out after nvme_tcp_try_recv() returns -EAGAIN.
During debugging I also found that we're quite lazy with the list
handling of requests, so I've added two preliminary patches to ensure
that all list elements are properly terminated.

As usual, comments and reviews are welcome.

Changes to v2:
- Removed AEN patches again

Changes to the original submission:
- Include reviews from Chris Leech
- Add patch to requeue namespace scan
- Add patch to re-read ANA log page

Hannes Reinecke (3):
  nvme-tcp: open-code nvme_tcp_queue_request() for R2T
  nvme-tcp: sanitize request list handling
  nvme-tcp: fix I/O stalls on congested sockets

 drivers/nvme/host/tcp.c | 32 ++++++++++++++++++++++++++------
 1 file changed, 26 insertions(+), 6 deletions(-)

-- 
2.35.3



             reply	other threads:[~2025-04-03  7:01 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03  6:55 Hannes Reinecke [this message]
2025-04-03  6:55 ` [PATCH 1/3] nvme-tcp: open-code nvme_tcp_queue_request() for R2T Hannes Reinecke
2025-04-13 22:56   ` Sagi Grimberg
2025-04-22  8:09   ` Christoph Hellwig
2025-04-03  6:55 ` [PATCH 2/3] nvme-tcp: sanitize request list handling Hannes Reinecke
2025-04-13 23:00   ` Sagi Grimberg
2025-04-14 12:35     ` Hannes Reinecke
2025-04-14 20:29       ` Sagi Grimberg
2025-04-03  6:55 ` [PATCH 3/3] nvme-tcp: fix I/O stalls on congested sockets Hannes Reinecke
2025-04-13 23:09   ` Sagi Grimberg
2025-04-14  6:21     ` Hannes Reinecke
2025-04-14 20:24       ` Sagi Grimberg
2025-04-15  7:07   ` Hannes Reinecke
2025-04-15 21:35     ` Sagi Grimberg
2025-04-16  7:56       ` Hannes Reinecke
2025-04-16 22:09         ` Sagi Grimberg
2025-04-17 23:03           ` Kamaljit Singh
2025-04-17 23:06             ` Kamaljit Singh
2025-04-18 10:51             ` Sagi Grimberg
2025-04-18 18:55               ` Kamaljit Singh
2025-04-19 16:10                 ` Sagi Grimberg
2025-04-21 19:11                   ` Kamaljit Singh
2025-04-22 11:43                     ` Sagi Grimberg
2025-04-23 17:26                       ` Kamaljit Singh
2025-04-24 11:26           ` Hannes Reinecke
2025-04-25 21:55             ` Sagi Grimberg
2025-04-25 22:09               ` Sagi Grimberg
2025-04-25 23:47                 ` Kamaljit Singh
2025-04-27 10:35                   ` Sagi Grimberg
     [not found]                     ` <BY5PR04MB6849D4BF87755B82A073BBDABC89A@BY5PR04MB6849.namprd04.prod.outlook.com>
2025-05-06 18:05                       ` Hannes Reinecke
2025-05-07 22:26                         ` Kamaljit Singh
2025-05-08 21:23                           ` Kamaljit Singh
2025-05-09  6:52                             ` Hannes Reinecke
2025-05-09  8:58                               ` Hannes Reinecke
2025-05-11  9:12                               ` Sagi Grimberg
2025-05-11  9:11                             ` Sagi Grimberg
2025-05-13 19:24                               ` Kamaljit Singh
2025-05-14  6:35                                 ` Hannes Reinecke
2025-05-17 10:01                                   ` Sagi Grimberg
2025-05-17 10:12                                     ` Sagi Grimberg
2025-05-27 21:49                                       ` Sagi Grimberg
2025-05-28  1:43                                         ` Kamaljit Singh
2025-05-28  6:33                                           ` Hannes Reinecke
2025-05-28 22:45                                             ` Kamaljit Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250403065522.90807-1-hare@kernel.org \
    --to=hare@kernel.org \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.