Re: [PATCH 5.4.y] RDMA/srpt: Support specifying the srpt_service_guid parameter

[Sasha Levin <sashal@kernel.org>]

[ Sasha's backport helper bot ]

Hi,

✅ All tests passed successfully. No issues detected.
No action required from the submitter.

The upstream commit SHA1 provided is correct: fdfa083549de5d50ebf7f6811f33757781e838c0

WARNING: Author mismatch between patch and upstream commit:
Backport author: Alok Tiwari<alok.a.tiwari@oracle.com>
Commit author: Bart Van Assche<bvanassche@acm.org>

Status in newer kernel trees:
6.13.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Present (different SHA1: fe2a73d57319)
6.1.y | Present (different SHA1: aee4dcfe1721)
5.15.y | Present (different SHA1: 989af2f29342)
5.10.y | Present (different SHA1: 5a5c039dac1b)

Note: The patch differs from the upstream commit:
---
1:  fdfa083549de5 ! 1:  f0d286e4cef27 RDMA/srpt: Support specifying the srpt_service_guid parameter
    @@ Metadata
      ## Commit message ##
         RDMA/srpt: Support specifying the srpt_service_guid parameter
     
    +    [ Upstream commit fdfa083549de5d50ebf7f6811f33757781e838c0 ]
    +
         Make loading ib_srpt with this parameter set work. The current behavior is
         that setting that parameter while loading the ib_srpt kernel module
         triggers the following kernel crash:
    @@ Commit message
         Signed-off-by: Bart Van Assche <bvanassche@acm.org>
         Link: https://lore.kernel.org/r/20240205004207.17031-1-bvanassche@acm.org
         Signed-off-by: Leon Romanovsky <leon@kernel.org>
    +    Signed-off-by: Sasha Levin <sashal@kernel.org>
    +    [Alok: Backport to 5.4.y since the commit has already been backported to
    +    5.15y, 5.10.y, and 4.19.y]
    +    Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
     
      ## drivers/infiniband/ulp/srpt/ib_srpt.c ##
     @@ drivers/infiniband/ulp/srpt/ib_srpt.c: module_param(srpt_srq_size, int, 0444);
    @@ drivers/infiniband/ulp/srpt/ib_srpt.c: module_param(srpt_srq_size, int, 0444);
     +}
      static int srpt_get_u64_x(char *buffer, const struct kernel_param *kp)
      {
    - 	return sprintf(buffer, "0x%016llx\n", *(u64 *)kp->arg);
    + 	return sprintf(buffer, "0x%016llx", *(u64 *)kp->arg);
      }
     -module_param_call(srpt_service_guid, NULL, srpt_get_u64_x, &srpt_service_guid,
     -		  0444);
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.4.y        |  Success    |  Success   |