From: Herve Codina <herve.codina@bootlin.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [RFC PATCH 1/3] i2c: core: Follow i2c-parent when retrieving an adapter from node
Date: Thu, 3 Apr 2025 14:21:14 +0200 [thread overview]
Message-ID: <20250403142114.2ca6722a@bootlin.com> (raw)
In-Reply-To: <Z-5u5bAnY8Y1DmFz@shikoro>
Hi Wolfram,
On Thu, 3 Apr 2025 13:20:05 +0200
Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> > The debug message can be interesting when things went wrong and we want
> > to investigate potential issue with i2c-parent chain from the last device
> > up to the adapter.
>
> I thought so but couldn't estimate how often this is useful in reality.
> I agree that introducing 'dev' is too much hazzle, yet I think the
> message should have some id to disitnguish potential different adapter
> chains. Either that, or...
>
> > I don't have a strong opinion about the need of this message and I can
> > simply remove it.
>
> ... we just remove it and let people add their debug stuff while
> developing.
I agree.
>
> > What is your preference ?
>
> A tad more 'removing'.
>
Will be removed.
Hervé
next prev parent reply other threads:[~2025-04-03 12:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 17:39 [RFC PATCH 0/3] i2c: Introduce i2c bus extensions Herve Codina
2025-02-05 17:39 ` [RFC PATCH 1/3] i2c: core: Follow i2c-parent when retrieving an adapter from node Herve Codina
2025-04-03 9:03 ` Wolfram Sang
2025-04-03 10:50 ` Herve Codina
2025-04-03 11:20 ` Wolfram Sang
2025-04-03 12:21 ` Herve Codina [this message]
2025-02-05 17:39 ` [RFC PATCH 2/3] i2c: i2c-core-of: Move children registration in a dedicated function Herve Codina
2025-04-03 9:07 ` Wolfram Sang
2025-04-03 10:51 ` Herve Codina
2025-02-05 17:39 ` [RFC PATCH 3/3] i2c: i2c-core-of: Handle i2c bus extensions Herve Codina
2025-02-12 5:54 ` Krzysztof Kozlowski
2025-02-12 9:45 ` Herve Codina
2025-04-03 9:09 ` Wolfram Sang
2025-02-19 13:38 ` [RFC PATCH 0/3] i2c: Introduce " Herve Codina
2025-03-20 12:49 ` Wolfram Sang
2025-03-20 16:31 ` Luca Ceresoli
2025-03-20 21:37 ` Wolfram Sang
2025-04-03 9:15 ` Wolfram Sang
2025-06-12 7:52 ` Ayush Singh
2025-06-13 7:30 ` Herve Codina
2025-07-03 11:26 ` Ayush Singh
2025-07-03 15:19 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250403142114.2ca6722a@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.