From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A07A14F9EB; Fri, 4 Apr 2025 00:08:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743725281; cv=none; b=ZLy786HseX4YVOpjxD9PgUHeXm0rBRsWF/17DIBkOEU+OnVZWqiBmdGJUsO8H8CwcPJpbtZ3jhwTCxZwm04YvPqm6amXy8HDkyvJAFmKIzt8jNGNVvUtnk3SMw/TTtbFsf9IDGYoFmIngTP0qOkP7Xq+ZUgLYUYLW77kwPJ/Kmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743725281; c=relaxed/simple; bh=xLyzOR5hGmlEjjKhed6HMgHMahwf9hr0eTGU0vzuFNk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iBtOSCSM4wikOmfjsj+b1VykPMkTTGHmsVHMNpvR7oIarwOuzDufnBiS3r5iPdk/enm30R9b9FOfOrO8tfaJ/J5xcWbFQ9z34G9fF/KbzNmEaurPzRh+7Xm1SFkchvOIP14scJEJE7hF3ZFChF34vTuoOhmUQgm7QcJ0Df4n2CQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X0aWhfMK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X0aWhfMK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AB03C4CEE3; Fri, 4 Apr 2025 00:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743725281; bh=xLyzOR5hGmlEjjKhed6HMgHMahwf9hr0eTGU0vzuFNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X0aWhfMKouQcnHybdXxXDdeug3UD5axuoaod1l17rouiz82DSmeZ/AFooNOz4D/xm KNa7OxwNgUkxJ4GMlMvWRxwW0rSU6xarq32DBERv91HW15UnVAKu7BcwHu/ucol+JR kqu/KHJ+px+yFtjXeqmol9XoG1u6tEzNQA6BHogqoHiamtzHJS/OiKq/ZomfwjbiY/ KHnoojKiqrQIDWS3dzLJr+rBWXU+q7ZCot2vKBD8llwkC9pA0DvJCIS12sp9VR2wVQ g8+vP4mtPdi9M6AvXPVK4mwG7372/vhwNZZKvHrhh2X2p4apZx3FC4GXs+qofVPSJY yYB/ipW1yElFw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kaixin Wang , Andy Shevchenko , Sebastian Reichel , Sasha Levin , sre@kernel.org Subject: [PATCH AUTOSEL 5.10 3/6] HSI: ssi_protocol: Fix use after free vulnerability in ssi_protocol Driver Due to Race Condition Date: Thu, 3 Apr 2025 20:07:46 -0400 Message-Id: <20250404000751.2689430-3-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250404000751.2689430-1-sashal@kernel.org> References: <20250404000751.2689430-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.235 Content-Transfer-Encoding: 8bit From: Kaixin Wang [ Upstream commit e3f88665a78045fe35c7669d2926b8d97b892c11 ] In the ssi_protocol_probe() function, &ssi->work is bound with ssip_xmit_work(), In ssip_pn_setup(), the ssip_pn_xmit() function within the ssip_pn_ops structure is capable of starting the work. If we remove the module which will call ssi_protocol_remove() to make a cleanup, it will free ssi through kfree(ssi), while the work mentioned above will be used. The sequence of operations that may lead to a UAF bug is as follows: CPU0 CPU1 | ssip_xmit_work ssi_protocol_remove | kfree(ssi); | | struct hsi_client *cl = ssi->cl; | // use ssi Fix it by ensuring that the work is canceled before proceeding with the cleanup in ssi_protocol_remove(). Signed-off-by: Kaixin Wang Acked-by: Andy Shevchenko Link: https://lore.kernel.org/r/20240918120749.1730-1-kxwang23@m.fudan.edu.cn Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/hsi/clients/ssi_protocol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c index 96d0eccca3aa7..8f7c4fd100d62 100644 --- a/drivers/hsi/clients/ssi_protocol.c +++ b/drivers/hsi/clients/ssi_protocol.c @@ -403,6 +403,7 @@ static void ssip_reset(struct hsi_client *cl) del_timer(&ssi->rx_wd); del_timer(&ssi->tx_wd); del_timer(&ssi->keep_alive); + cancel_work_sync(&ssi->work); ssi->main_state = 0; ssi->send_state = 0; ssi->recv_state = 0; -- 2.39.5