From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Nilay Shroff <nilay@linux.ibm.com>,
Christoph Hellwig <hch@lst.de>,
syzbot+9dd7dbb1a4b915dee638@syzkaller.appspotmail.com
Subject: Re: [PATCH] loop: replace freezing queue with quiesce when changing loop specific setting
Date: Fri, 4 Apr 2025 11:11:49 +0200 [thread overview]
Message-ID: <20250404091149.GC12163@lst.de> (raw)
In-Reply-To: <20250403105414.1334254-1-ming.lei@redhat.com>
On Thu, Apr 03, 2025 at 06:54:14PM +0800, Ming Lei wrote:
> freeze queue should be used for changing block layer generic setting, such
> as logical block size, PI, ..., and it is enough to quiesce queue for
> changing loop specific setting.
Why? A queue should generally be frozen for any setting affecting the
I/O path. Nothing about generic or internal.
This also misses an explanation of what setting this protects and why
you think this is safe and the sound fix.
next prev parent reply other threads:[~2025-04-04 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 10:54 [PATCH] loop: replace freezing queue with quiesce when changing loop specific setting Ming Lei
2025-04-03 20:04 ` Zhu Yanjun
2025-04-04 9:11 ` Christoph Hellwig [this message]
2025-04-04 12:06 ` Ming Lei
2025-04-07 6:48 ` Christoph Hellwig
2025-04-07 14:54 ` Ming Lei
2025-04-08 5:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404091149.GC12163@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=syzbot+9dd7dbb1a4b915dee638@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.