From: Christoph Hellwig <hch@lst.de>
To: Chanho Min <chanho.min@lge.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Sven <dm-devel@schwermer.no>, Neil Brown <neilb@suse.de>,
hch@lst.de, dm-devel@lists.linux.dev,
Gunho Lee <gunho.lee@lge.com>
Subject: Re: [PATCH] block: remove non-existent partition dev_t return from blk_lookup_devt
Date: Fri, 4 Apr 2025 11:20:19 +0200 [thread overview]
Message-ID: <20250404092019.GA13334@lst.de> (raw)
In-Reply-To: <20250403003532.412-1-chanho.min@lge.com>
NAK.
Don't do this. Md at least has a reason for doing this silly things
as in the code as written in the 1990s where people did not know better.
The dm-initwait code has no such excuse as it was written recently and
explicitly ignored the rules to not use this early dev_t lookup code that
is known to be broken. You now have to live with the fallout because you
decided to you this broken code. Stop using it if you care.
If there's one thing we need to do is to warn everyone in the Kconfig
and boot time dmesg that dm-initwait is broken.
prev parent reply other threads:[~2025-04-04 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 0:35 [PATCH] block: remove non-existent partition dev_t return from blk_lookup_devt Chanho Min
2025-04-04 9:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404092019.GA13334@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=chanho.min@lge.com \
--cc=dm-devel@lists.linux.dev \
--cc=dm-devel@schwermer.no \
--cc=gunho.lee@lge.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.