All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
Cc: outreachy@lists.linux.dev, julia.lawall@inria.fr,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	andy@kernel.org
Subject: Re: [v3 0/1] Unnecessary code cleanup patches
Date: Sat, 5 Apr 2025 09:36:21 +0100	[thread overview]
Message-ID: <2025040505-blip-mower-bab6@gregkh> (raw)
In-Reply-To: <cover.1743723590.git.abrahamadekunle50@gmail.com>

On Fri, Apr 04, 2025 at 01:02:19AM +0100, Abraham Samuel Adekunle wrote:
> The patchset modifies unnecessary duplicate NULL test on a
> value in an expression, when the value has been NULL tested in a
> previous expression.

Nit, the subject line does nto have "staging:" in it, so I don't know
where this goes.

Also, it really reads as "this is an unnecessary patch" :)

And finally, for a single patch, there's usually not a need for a 0/X
email to describe it, everything should be in just the single patch
itself.

thanks,

greg k-h

  parent reply	other threads:[~2025-04-05  8:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04  0:02 [v3 0/1] Unnecessary code cleanup patches Abraham Samuel Adekunle
2025-04-04  0:02 ` [v3 1/1] staging: rtl8723bs: Prevent duplicate NULL tests on a value Abraham Samuel Adekunle
2025-04-04  7:53   ` Andy Shevchenko
2025-04-04  7:58     ` Samuel Abraham
2025-04-04  9:06     ` Dan Carpenter
2025-04-04 10:13       ` Samuel Abraham
2025-04-04 10:53       ` Andy Shevchenko
2025-04-04 11:47         ` Dan Carpenter
2025-04-05  8:36 ` Greg KH [this message]
2025-04-05  8:49   ` [v3 0/1] Unnecessary code cleanup patches Julia Lawall
2025-04-05 11:18     ` Samuel Abraham
2025-04-05 11:15   ` Samuel Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025040505-blip-mower-bab6@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=abrahamadekunle50@gmail.com \
    --cc=andy@kernel.org \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.