From: Nilay Shroff <nilay@linux.ibm.com>
To: linux-nvme@lists.infradead.org
Cc: dwagner@suse.de, hare@kernel.org, kbusch@kernel.org, gjoyce@ibm.com
Subject: [PATCH 2/3] tree: add queue-depth attribute for nvme path object
Date: Sat, 5 Apr 2025 18:32:48 +0530 [thread overview]
Message-ID: <20250405130255.448345-3-nilay@linux.ibm.com> (raw)
In-Reply-To: <20250405130255.448345-1-nilay@linux.ibm.com>
Add a new attribute named "queue_depth" under the NVMe path object. This
attribute is used by the iopolicy "queue-depth", which was introduced in
kernel v6.11. However, the corresponding sysfs attribute for queue depth
was only added in kernel v6.14.
The queue_depth value can be useful for observing which paths are selected
for I/O forwarding, based on the depth of each path. To support this,
export the attribute in libnvme.map so it can be accessed via nvme-cli.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
---
src/libnvme.map | 1 +
src/nvme/private.h | 1 +
src/nvme/tree.c | 12 +++++++++++-
src/nvme/tree.h | 8 ++++++++
4 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/src/libnvme.map b/src/libnvme.map
index 4314705f..e53fad6b 100644
--- a/src/libnvme.map
+++ b/src/libnvme.map
@@ -317,6 +317,7 @@ LIBNVME_1_0 {
nvme_path_get_ctrl;
nvme_path_get_name;
nvme_path_get_ns;
+ nvme_path_get_queue_depth;
nvme_path_get_sysfs_dir;
nvme_paths_filter;
nvme_read_config;
diff --git a/src/nvme/private.h b/src/nvme/private.h
index f45c5823..f94276e2 100644
--- a/src/nvme/private.h
+++ b/src/nvme/private.h
@@ -34,6 +34,7 @@ struct nvme_path {
char *sysfs_dir;
char *ana_state;
int grpid;
+ int queue_depth;
};
struct nvme_ns_head {
diff --git a/src/nvme/tree.c b/src/nvme/tree.c
index bd7fb53e..b7a38a07 100644
--- a/src/nvme/tree.c
+++ b/src/nvme/tree.c
@@ -903,6 +903,11 @@ const char *nvme_path_get_name(nvme_path_t p)
return p->name;
}
+int nvme_path_get_queue_depth(nvme_path_t p)
+{
+ return p->queue_depth;
+}
+
const char *nvme_path_get_ana_state(nvme_path_t p)
{
return p->ana_state;
@@ -921,7 +926,7 @@ void nvme_free_path(struct nvme_path *p)
static int nvme_ctrl_scan_path(nvme_root_t r, struct nvme_ctrl *c, char *name)
{
struct nvme_path *p;
- _cleanup_free_ char *path = NULL, *grpid = NULL;
+ _cleanup_free_ char *path = NULL, *grpid = NULL, *queue_depth = NULL;
int ret;
nvme_msg(r, LOG_DEBUG, "scan controller %s path %s\n",
@@ -955,6 +960,11 @@ static int nvme_ctrl_scan_path(nvme_root_t r, struct nvme_ctrl *c, char *name)
sscanf(grpid, "%d", &p->grpid);
}
+ queue_depth = nvme_get_path_attr(p, "queue_depth");
+ if (queue_depth) {
+ sscanf(queue_depth, "%d", &p->queue_depth);
+ }
+
list_node_init(&p->nentry);
list_node_init(&p->entry);
list_add_tail(&c->paths, &p->entry);
diff --git a/src/nvme/tree.h b/src/nvme/tree.h
index 9f382e9c..a9082f8e 100644
--- a/src/nvme/tree.h
+++ b/src/nvme/tree.h
@@ -867,6 +867,14 @@ const char *nvme_path_get_sysfs_dir(nvme_path_t p);
*/
const char *nvme_path_get_ana_state(nvme_path_t p);
+/**
+ * nvme_path_get_queue_depth() - Queue depth of an nvme_path_t object
+ * @p: &nvme_path_t object
+ *
+ * Return: Queue depth of @p
+ */
+int nvme_path_get_queue_depth(nvme_path_t p);
+
/**
* nvme_path_get_ctrl() - Parent controller of an nvme_path_t object
* @p: &nvme_path_t object
--
2.49.0
next prev parent reply other threads:[~2025-04-05 13:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-05 13:02 [PATCH 0/3] libnvme: add support for discovering multipath of a shared ns Nilay Shroff
2025-04-05 13:02 ` [PATCH 1/3] tree: add support for discovering nvme paths using sysfs multipath link Nilay Shroff
2025-04-07 7:19 ` Daniel Wagner
2025-04-07 9:36 ` Nilay Shroff
2025-04-07 11:01 ` Daniel Wagner
2025-04-07 13:43 ` Nilay Shroff
2025-04-05 13:02 ` Nilay Shroff [this message]
2025-04-07 7:40 ` [PATCH 2/3] tree: add queue-depth attribute for nvme path object Daniel Wagner
2025-04-05 13:02 ` [PATCH 3/3] tree: add attribute numa_nodes for NVMe " Nilay Shroff
2025-04-07 7:44 ` Daniel Wagner
2025-04-07 9:59 ` Nilay Shroff
2025-04-07 11:10 ` Daniel Wagner
2025-04-07 14:19 ` Nilay Shroff
2025-04-07 15:19 ` Daniel Wagner
2025-04-08 5:58 ` Hannes Reinecke
2025-04-08 11:42 ` Daniel Wagner
2025-04-08 11:48 ` Hannes Reinecke
2025-04-09 9:38 ` Nilay Shroff
2025-04-09 11:36 ` Daniel Wagner
2025-04-05 16:15 ` [PATCH 0/3] libnvme: add support for discovering multipath of a shared ns Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250405130255.448345-3-nilay@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=dwagner@suse.de \
--cc=gjoyce@ibm.com \
--cc=hare@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.