Re: [PATCH v4 03/10] ASoC: tas2770: Set the SDOUT polarity correctly

[kernel test robot <lkp@intel.com>]

Hi James,

kernel test robot noticed the following build errors:

[auto build test ERROR on 3a0f0a4355df0240485ed62b6bd6afa5b3e689c5]

url:    https://github.com/intel-lab-lkp/linux/commits/James-Calligeros/ASoC-tas2770-Power-cycle-amp-on-ISENSE-VSENSE-change/20250405-081800
base:   3a0f0a4355df0240485ed62b6bd6afa5b3e689c5
patch link:    https://lore.kernel.org/r/20250405-apple-codec-changes-v4-3-d007e46ce4a2%40gmail.com
patch subject: [PATCH v4 03/10] ASoC: tas2770: Set the SDOUT polarity correctly
config: arc-randconfig-001-20250406 (https://download.01.org/0day-ci/archive/20250406/202504060322.XScsxcUB-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250406/202504060322.XScsxcUB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504060322.XScsxcUB-lkp@intel.com/

All errors (new ones prefixed by >>):

   sound/soc/codecs/tas2770.c: In function 'tas2770_set_fmt':
>> sound/soc/codecs/tas2770.c:371:30: error: 'TAS2770_TDM_CFG_REG4_TX_EDGE_FALLING' undeclared (first use in this function); did you mean 'TAS2770_TDM_CFG_REG1_RX_FALING'?
     371 |                 asi_cfg_4 |= TAS2770_TDM_CFG_REG4_TX_EDGE_FALLING;
         |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                              TAS2770_TDM_CFG_REG1_RX_FALING
   sound/soc/codecs/tas2770.c:371:30: note: each undeclared identifier is reported only once for each function it appears in
>> sound/soc/codecs/tas2770.c:390:56: error: 'TAS2770_TDM_CFG_REG4' undeclared (first use in this function); did you mean 'TAS2770_TDM_CFG_REG7'?
     390 |         ret = snd_soc_component_update_bits(component, TAS2770_TDM_CFG_REG4,
         |                                                        ^~~~~~~~~~~~~~~~~~~~
         |                                                        TAS2770_TDM_CFG_REG7


vim +371 sound/soc/codecs/tas2770.c

   348	
   349	static int tas2770_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
   350	{
   351		struct snd_soc_component *component = dai->component;
   352		struct tas2770_priv *tas2770 =
   353				snd_soc_component_get_drvdata(component);
   354		u8 tdm_rx_start_slot = 0, invert_fpol = 0, fpol_preinv = 0, asi_cfg_1 = 0, asi_cfg_4 = 0;
   355		int ret;
   356	
   357		switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
   358		case SND_SOC_DAIFMT_CBC_CFC:
   359			break;
   360		default:
   361			dev_err(tas2770->dev, "ASI invalid DAI clocking\n");
   362			return -EINVAL;
   363		}
   364	
   365		switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
   366		case SND_SOC_DAIFMT_NB_IF:
   367			invert_fpol = 1;
   368			fallthrough;
   369		case SND_SOC_DAIFMT_NB_NF:
   370			asi_cfg_1 |= TAS2770_TDM_CFG_REG1_RX_RSING;
 > 371			asi_cfg_4 |= TAS2770_TDM_CFG_REG4_TX_EDGE_FALLING;
   372			break;
   373		case SND_SOC_DAIFMT_IB_IF:
   374			invert_fpol = 1;
   375			fallthrough;
   376		case SND_SOC_DAIFMT_IB_NF:
   377			asi_cfg_1 |= TAS2770_TDM_CFG_REG1_RX_FALING;
   378			break;
   379		default:
   380			dev_err(tas2770->dev, "ASI format Inverse is not found\n");
   381			return -EINVAL;
   382		}
   383	
   384		ret = snd_soc_component_update_bits(component, TAS2770_TDM_CFG_REG1,
   385						    TAS2770_TDM_CFG_REG1_RX_MASK,
   386						    asi_cfg_1);
   387		if (ret < 0)
   388			return ret;
   389	
 > 390		ret = snd_soc_component_update_bits(component, TAS2770_TDM_CFG_REG4,
   391						    TAS2770_TDM_CFG_REG4_TX_EDGE_FALLING,
   392						    asi_cfg_4);
   393		if (ret < 0)
   394			return ret;
   395	
   396		switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
   397		case SND_SOC_DAIFMT_I2S:
   398			tdm_rx_start_slot = 1;
   399			fpol_preinv = 0;
   400			break;
   401		case SND_SOC_DAIFMT_DSP_A:
   402			tdm_rx_start_slot = 0;
   403			fpol_preinv = 1;
   404			break;
   405		case SND_SOC_DAIFMT_DSP_B:
   406			tdm_rx_start_slot = 1;
   407			fpol_preinv = 1;
   408			break;
   409		case SND_SOC_DAIFMT_LEFT_J:
   410			tdm_rx_start_slot = 0;
   411			fpol_preinv = 1;
   412			break;
   413		default:
   414			dev_err(tas2770->dev,
   415				"DAI Format is not found, fmt=0x%x\n", fmt);
   416			return -EINVAL;
   417		}
   418	
   419		ret = snd_soc_component_update_bits(component, TAS2770_TDM_CFG_REG1,
   420						    TAS2770_TDM_CFG_REG1_MASK,
   421						    (tdm_rx_start_slot << TAS2770_TDM_CFG_REG1_51_SHIFT));
   422		if (ret < 0)
   423			return ret;
   424	
   425		ret = snd_soc_component_update_bits(component, TAS2770_TDM_CFG_REG0,
   426						    TAS2770_TDM_CFG_REG0_FPOL_MASK,
   427						    (fpol_preinv ^ invert_fpol)
   428						     ? TAS2770_TDM_CFG_REG0_FPOL_RSING
   429						     : TAS2770_TDM_CFG_REG0_FPOL_FALING);
   430		if (ret < 0)
   431			return ret;
   432	
   433		return 0;
   434	}
   435	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki