From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Weilin Wang <weilin.wang@intel.com>,
James Clark <james.clark@linaro.org>,
Xu Yang <xu.yang_2@nxp.com>,
John Garry <john.g.garry@oracle.com>,
Howard Chu <howardchu95@gmail.com>,
Levi Yun <yeoreum.yun@arm.com>,
Dominique Martinet <asmadeus@codewreck.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 01/16] perf intel-tpebs: Cleanup header
Date: Sun, 6 Apr 2025 22:00:46 -0700 [thread overview]
Message-ID: <20250407050101.1389825-2-irogers@google.com> (raw)
In-Reply-To: <20250407050101.1389825-1-irogers@google.com>
Remove arch conditional compilation. Arch conditional compilation
belongs in the arch/ directory.
Tidy header guards to match other files. Remove unneeded includes and
switch to forward declarations when necesary.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/Build | 2 +-
tools/perf/util/intel-tpebs.c | 1 +
tools/perf/util/intel-tpebs.h | 30 ++++++------------------------
3 files changed, 8 insertions(+), 25 deletions(-)
diff --git a/tools/perf/util/Build b/tools/perf/util/Build
index 946bce6628f3..815274b199fd 100644
--- a/tools/perf/util/Build
+++ b/tools/perf/util/Build
@@ -161,7 +161,7 @@ perf-util-y += clockid.o
perf-util-y += list_sort.o
perf-util-y += mutex.o
perf-util-y += sharded_mutex.o
-perf-util-$(CONFIG_X86_64) += intel-tpebs.o
+perf-util-y += intel-tpebs.o
perf-util-$(CONFIG_LIBBPF) += bpf_map.o
perf-util-$(CONFIG_PERF_BPF_SKEL) += bpf_counter.o
diff --git a/tools/perf/util/intel-tpebs.c b/tools/perf/util/intel-tpebs.c
index 2c421b475b3b..3503da28a12f 100644
--- a/tools/perf/util/intel-tpebs.c
+++ b/tools/perf/util/intel-tpebs.c
@@ -19,6 +19,7 @@
#include "tool.h"
#include "cpumap.h"
#include "metricgroup.h"
+#include "stat.h"
#include <sys/stat.h>
#include <sys/file.h>
#include <poll.h>
diff --git a/tools/perf/util/intel-tpebs.h b/tools/perf/util/intel-tpebs.h
index 766b3fbd79f1..63c16e759a71 100644
--- a/tools/perf/util/intel-tpebs.h
+++ b/tools/perf/util/intel-tpebs.h
@@ -2,34 +2,16 @@
/*
* intel_tpebs.h: Intel TEPBS support
*/
-#ifndef INCLUDE__PERF_INTEL_TPEBS_H__
-#define INCLUDE__PERF_INTEL_TPEBS_H__
+#ifndef __INTEL_TPEBS_H
+#define __INTEL_TPEBS_H
-#include "stat.h"
-#include "evsel.h"
-
-#ifdef HAVE_ARCH_X86_64_SUPPORT
+struct evlist;
+struct evsel;
extern bool tpebs_recording;
+
int tpebs_start(struct evlist *evsel_list);
void tpebs_delete(void);
int tpebs_set_evsel(struct evsel *evsel, int cpu_map_idx, int thread);
-#else
-
-static inline int tpebs_start(struct evlist *evsel_list __maybe_unused)
-{
- return 0;
-}
-
-static inline void tpebs_delete(void) {};
-
-static inline int tpebs_set_evsel(struct evsel *evsel __maybe_unused,
- int cpu_map_idx __maybe_unused,
- int thread __maybe_unused)
-{
- return 0;
-}
-
-#endif
-#endif
+#endif /* __INTEL_TPEBS_H */
--
2.49.0.504.g3bcea36a83-goog
next prev parent reply other threads:[~2025-04-07 5:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 5:00 [PATCH v2 00/16] Intel TPEBS min/max/mean/last support Ian Rogers
2025-04-07 5:00 ` Ian Rogers [this message]
2025-04-07 5:00 ` [PATCH v2 02/16] perf intel-tpebs: Simplify tpebs_cmd Ian Rogers
2025-04-07 5:00 ` [PATCH v2 03/16] perf intel-tpebs: Rename tpebs_start to evsel__tpebs_open Ian Rogers
2025-04-07 5:00 ` [PATCH v2 04/16] perf intel-tpebs: Separate evsel__tpebs_prepare out of evsel__tpebs_open Ian Rogers
2025-04-07 5:00 ` [PATCH v2 05/16] perf intel-tpebs: Move cpumap_buf " Ian Rogers
2025-04-07 5:00 ` [PATCH v2 06/16] perf intel-tpebs: Reduce scope of tpebs_events_size Ian Rogers
2025-04-07 5:00 ` [PATCH v2 07/16] perf intel-tpebs: Inline get_perf_record_args Ian Rogers
2025-04-07 5:00 ` [PATCH v2 08/16] perf intel-tpebs: Ensure events are opened, factor out finding Ian Rogers
2025-04-07 5:00 ` [PATCH v2 09/16] perf intel-tpebs: Refactor tpebs_results list Ian Rogers
2025-04-07 19:33 ` Liang, Kan
2025-04-07 20:03 ` Ian Rogers
2025-04-07 5:00 ` [PATCH v2 10/16] perf intel-tpebs: Add support for updating counts in evsel__tpebs_read Ian Rogers
2025-04-07 19:37 ` Liang, Kan
2025-04-07 20:07 ` Ian Rogers
2025-04-07 5:00 ` [PATCH v2 11/16] perf intel-tpebs: Add mutex for tpebs_results Ian Rogers
2025-04-07 19:49 ` Liang, Kan
2025-04-07 20:10 ` Ian Rogers
2025-04-07 5:00 ` [PATCH v2 12/16] perf intel-tpebs: Don't close record on read Ian Rogers
2025-04-07 5:00 ` [PATCH v2 13/16] perf intel-tpebs: Use stats for retirement latency statistics Ian Rogers
2025-04-07 20:39 ` kernel test robot
2025-04-07 5:00 ` [PATCH v2 14/16] perf stat: Add mean, min, max and last --tpebs-mode options Ian Rogers
2025-04-07 19:56 ` Liang, Kan
2025-04-07 20:10 ` Ian Rogers
2025-04-07 5:01 ` [PATCH v2 15/16] perf pmu-events: Add retirement latency to JSON events inside of perf Ian Rogers
2025-04-07 5:01 ` [PATCH v2 16/16] perf record: Retirement latency cleanup in evsel__config Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250407050101.1389825-2-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=asmadeus@codewreck.org \
--cc=howardchu95@gmail.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=weilin.wang@intel.com \
--cc=xu.yang_2@nxp.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.